-
Notifications
You must be signed in to change notification settings - Fork 78
Add site.alleles method #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add site.alleles method #2385
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2385 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 28 28
Lines 26917 26921 +4
Branches 1239 1240 +1
=======================================
+ Hits 25111 25115 +4
Misses 1772 1772
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some suggeestions
benjeffery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test where the ancestral state is not a single character? Easy to trip up when python does things like this:
>>> a = "foobar"
>>> set(a)
{'f', 'o', 'b', 'a', 'r'}
>>> {a}
{'foobar'}Deliberately returns an (unordered) set
|
Comments addressed. Thanks @jeromekelleher and @benjeffery. Ready to merge I think. |
Description
Deliberately returns an (unordered) set
Fixes #2380
PR Checklist: