Skip to content

Conversation

@hyanwong
Copy link
Member

@hyanwong hyanwong commented Jul 6, 2022

Description

Deliberately returns an (unordered) set

Fixes #2380

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2385 (a847133) into main (845ccec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a847133 differs from pull request most recent head 62d70f4. Consider uploading reports for the commit 62d70f4 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          28       28           
  Lines       26917    26921    +4     
  Branches     1239     1240    +1     
=======================================
+ Hits        25111    25115    +4     
  Misses       1772     1772           
  Partials       34       34           
Flag Coverage Δ
c-tests 92.25% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 70.99% <25.00%> (-0.02%) ⬇️
python-tests 98.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.16% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845ccec...62d70f4. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some suggeestions

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where the ancestral state is not a single character? Easy to trip up when python does things like this:

>>> a = "foobar"
>>> set(a)
{'f', 'o', 'b', 'a', 'r'}
>>> {a}
{'foobar'}

Deliberately returns an (unordered) set
@hyanwong
Copy link
Member Author

hyanwong commented Jul 8, 2022

Comments addressed. Thanks @jeromekelleher and @benjeffery. Ready to merge I think.

@mergify mergify bot merged commit b07b3e2 into tskit-dev:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site.alleles() method?

3 participants