Skip to content

Conversation

@hyanwong
Copy link
Member

@hyanwong hyanwong commented Dec 23, 2022

Description

Fixes #2620

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #2669 (f70a1a6) into main (1167966) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2669   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          28       28           
  Lines       27812    27814    +2     
  Branches     1281     1281           
=======================================
+ Hits        26127    26129    +2     
  Misses       1648     1648           
  Partials       37       37           
Flag Coverage Δ
c-tests 92.26% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.94% <50.00%> (-0.01%) ⬇️
python-tests 98.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1167966...f70a1a6. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hyanwong! I've made some suggestions about testing.
I'm confused about how Tree.roots takes account of root_threshold, but I assume I'm missing something.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tree.is_root() method

3 participants