Skip to content

Conversation

@hyanwong
Copy link
Member

@hyanwong hyanwong commented Jun 6, 2025

Only 3 lines in drawing.py, and a single test.

The rest of the churn is the pre-saved SVGs, sorry

Fixes #557

@hyanwong hyanwong changed the title Add an edge ID Add an edge ID to the SVG output Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (ef025a0) to head (22a0392).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3193   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files          28       28           
  Lines       31969    31971    +2     
  Branches     5873     5873           
=======================================
+ Hits        28653    28655    +2     
  Misses       1886     1886           
  Partials     1430     1430           
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/drawing.py 98.35% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Worth a changelog?

Only 3 lines in drawing.py, and a single test.

The rest of the churn is the pre-saved SVGs, sorry
@hyanwong hyanwong enabled auto-merge June 6, 2025 15:10
@hyanwong hyanwong added this pull request to the merge queue Jun 6, 2025
Merged via the queue into tskit-dev:main with commit 1a1e75e Jun 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add edge ids to the SVG representation of a tree

3 participants