-
Notifications
You must be signed in to change notification settings - Fork 78
Create Tree.as_dict_of_dicts() method for conversion to networkx.Graph/DiGraph #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 87.31% 87.32% +<.01%
==========================================
Files 21 21
Lines 15416 15423 +7
Branches 2996 2998 +2
==========================================
+ Hits 13461 13468 +7
Misses 969 969
Partials 986 986
Continue to review full report at Codecov.
|
|
@jeromekelleher I think I have the basic functionality down now. Are there any tests or other features you'd like to see? If not, then the next step is to remove all of those print statements, add some documentation and make an entry in the tutorial. |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is AWESOME thanks @winni2k! Some comments above.
|
I've implemented all suggestions except for the |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @winni2k. A few more minor comments and we're good to merge.
Can you squash the commits also please?
2af562c to
982b904
Compare
|
All done |
|
🥁 |
This is a PR stub for the feature described in #456.