Skip to content

Conversation

@benjeffery
Copy link
Member

Closes #512

This method is called by jupyter notebooks to display nice-looking tables. Here's a screenshot:
Screenshot from 2020-04-07 01-01-32

@benjeffery
Copy link
Member Author

No idea why the docs are broken, they build locally. Will fix the CI tomorrow, but def not the fault of these changes.

@jeromekelleher
Copy link
Member

Very tidy, I like it!

@jeromekelleher
Copy link
Member

One to add to the CHANGELOG too.

@benjeffery
Copy link
Member Author

@jeromekelleher changelog added (fixed up a few other entries too)

@jeromekelleher
Copy link
Member

Looks like the docs build is failing because of a new sphinx version. Sigh.

@benjeffery
Copy link
Member Author

Things like this are why deps should be version-pinned, at least for the CI. At the moment the CI isn't deterministic. We can use https://dependabot.com/ to keep the pinned versions up-to-date. It submits PRs automatically and we would see the CI break there instead of here.

@benjeffery
Copy link
Member Author

@jeromekelleher I'm fixing the docs - will be in a diff PR.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #514 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   86.82%   86.84%   +0.01%     
==========================================
  Files          21       21              
  Lines       15979    15996      +17     
  Branches     3105     3109       +4     
==========================================
+ Hits        13874    13891      +17     
  Misses       1055     1055              
  Partials     1050     1050              
Flag Coverage Δ
#c_tests 87.75% <100.00%> (+0.01%) ⬆️
#python_c_tests 90.55% <100.00%> (+0.02%) ⬆️
#python_tests 99.18% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
python/tskit/tables.py 99.80% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7544b88...0ae4523. Read the comment docs.

@jeromekelleher jeromekelleher merged commit 413c4ed into tskit-dev:master Apr 7, 2020
@benjeffery benjeffery deleted the table_html branch April 18, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jupyter notebook friendly output for tables

2 participants