Skip to content

Conversation

@benjeffery
Copy link
Member

As #491 was getting very large we decided to split it again. This PR adds methods to the Python C module to get/set metadata schema as a *Table attribute, and to the get the group of schemas as a method on TreeSequence

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #542 into master will decrease coverage by 0.10%.
The diff coverage is 76.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   87.26%   87.16%   -0.11%     
==========================================
  Files          21       21              
  Lines       16037    16200     +163     
  Branches     3132     3172      +40     
==========================================
+ Hits        13995    14120     +125     
- Misses       1006     1020      +14     
- Partials     1036     1060      +24     
Flag Coverage Δ
#c_tests 88.33% <ø> (ø)
#python_c_tests 90.24% <76.82%> (-0.31%) ⬇️
#python_tests ?
Impacted Files Coverage Δ
python/_tskitmodule.c 83.93% <76.82%> (-0.29%) ⬇️
python/tskit/trees.py 98.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684a902...ecdf03d. Read the comment docs.

@benjeffery benjeffery marked this pull request as ready for review April 17, 2020 23:21
@benjeffery benjeffery mentioned this pull request Apr 18, 2020
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @benjeffery. A couple of minor comments above, and I think we're good to merge.

Can you confirm that python3 stress_lowlevel.py -m lowlevel shows we have no leaks?

@benjeffery
Copy link
Member Author

benjeffery commented Apr 20, 2020

@jeromekelleher looks good to me:

(env) benj@treebeard:~/projects/tskit/python$ python3 stress_lowlevel.py -m lowlevel
iter    tests    err    fail    skip	RSS      min    max      max@iter
317     166      0	    0       0	    78668    78336	78668    2

If you're happy I'll squash rebase.

@jeromekelleher
Copy link
Member

Great thanks, let's merge.

@benjeffery
Copy link
Member Author

Travis failure is on push trigger only. pr trigger is passing.

@benjeffery benjeffery merged commit 64ff36b into tskit-dev:master Apr 20, 2020
@benjeffery benjeffery deleted the metadata_C_module branch April 20, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants