-
Notifications
You must be signed in to change notification settings - Fork 78
Add metadata schema methods to Python C module #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 87.26% 87.16% -0.11%
==========================================
Files 21 21
Lines 16037 16200 +163
Branches 3132 3172 +40
==========================================
+ Hits 13995 14120 +125
- Misses 1006 1020 +14
- Partials 1036 1060 +24
Continue to review full report at Codecov.
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @benjeffery. A couple of minor comments above, and I think we're good to merge.
Can you confirm that python3 stress_lowlevel.py -m lowlevel shows we have no leaks?
|
@jeromekelleher looks good to me: If you're happy I'll squash rebase. |
|
Great thanks, let's merge. |
fc229a4 to
ecdf03d
Compare
|
Travis failure is on |
As #491 was getting very large we decided to split it again. This PR adds methods to the Python C module to get/set metadata schema as a
*Tableattribute, and to the get the group of schemas as a method onTreeSequence