-
Notifications
You must be signed in to change notification settings - Fork 79
Test stats when not all samples are included. #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hm, this failed but for unrelated reasons!?!? Running it on my laptop atm. |
|
Yeah, some concurrency bug has shown up in macos latest python 3.6 recently. We should fix ASAP I guess, or just disable the test for now. @benjeffery, have you spotted this one? |
|
Not seen that one before #1041 |
|
@Mergifyio rebase |
|
Command
|
4669718 to
fc470ed
Compare
|
passed! |
|
I think the failures here are all due to the concurrency bug we've figured out, so I think we can reset |
fc470ed to
7ecfd58
Compare
|
Reset |
|
📖 Docs for this PR can be previewed here |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 26 26
Lines 20985 20985
Branches 875 875
=======================================
Hits 19659 19659
Misses 1289 1289
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
7ecfd58 to
a7c9e66
Compare
Over in #1023 I noticed that some tests were passing that shouldn't, because all of our tests in
test_tree_stats.pyhad the property that the union of all sample sets was equal to the set of all samples. This fixes this oversight (and hopefully everything still works, eek!).I've also set (temporarily!!) it to run all the tests in
test_tree_stats.py, but will need to change that back so that testing doesn't take forever.