Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #1134

@benjeffery benjeffery marked this pull request as ready for review February 1, 2021 16:04
@benjeffery benjeffery force-pushed the individual-parents-docs branch from 684beb1 to 817b252 Compare February 1, 2021 16:06
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1178 (34bc9e7) into main (9fb2bf6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          26       26           
  Lines       21254    21254           
  Branches      902      902           
=======================================
  Hits        19922    19922           
  Misses       1294     1294           
  Partials       38       38           
Flag Coverage Δ
c-tests 92.52% <ø> (ø)
lwt-tests 92.97% <ø> (ø)
python-c-tests 94.89% <ø> (ø)
python-tests 98.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/tables.py 99.60% <ø> (ø)
python/tskit/trees.py 97.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb2bf6...34bc9e7. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nit

:param array-like location: A list of numeric values or one-dimensional numpy
array describing the location of this individual. If not specified
or None, a zero-dimensional location is stored.
:param array-like parents: A list or array of ids of parent individuals If not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full stop before "If"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AdminBot-tskit AdminBot-tskit force-pushed the individual-parents-docs branch from 5a815a4 to 34bc9e7 Compare February 2, 2021 01:56
@mergify mergify bot merged commit ed2381c into tskit-dev:main Feb 2, 2021
@benjeffery benjeffery deleted the individual-parents-docs branch March 19, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for Indvidual.parents

2 participants