Skip to content

Make the default margins accessible as attributes#3196

Merged
benjeffery merged 1 commit into
tskit-dev:mainfrom
hyanwong:svg-nits
Jun 6, 2025
Merged

Make the default margins accessible as attributes#3196
benjeffery merged 1 commit into
tskit-dev:mainfrom
hyanwong:svg-nits

Conversation

@hyanwong
Copy link
Copy Markdown
Member

@hyanwong hyanwong commented Jun 6, 2025

Trivial, but helps when e.g. calculating point positions on the plot, which I'm doing for e.g. making tangle grams. No need to document (yet)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (1a1e75e) to head (da18351).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3196   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files          28       28           
  Lines       31971    31975    +4     
  Branches     5873     5873           
=======================================
+ Hits        28655    28659    +4     
  Misses       1886     1886           
  Partials     1430     1430           
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/drawing.py 98.35% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Trivial, but helps when e.g. calculating plot positions
@benjeffery benjeffery added this pull request to the merge queue Jun 6, 2025
Merged via the queue into tskit-dev:main with commit accc1de Jun 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants