-
Notifications
You must be signed in to change notification settings - Fork 78
Documentation/Consistency Review #3329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3329 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 29 29
Lines 31181 31192 +11
Branches 5720 5722 +2
=======================================
+ Hits 27976 27988 +12
Misses 1796 1796
+ Partials 1409 1408 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through and it all looks good to me except for the IBDsegments stuff, which I'd have to spend more time on. I'd suggest pulling this commit out into it's own PR, and get the rest merged.
docs/stats.md
Outdated
| statistics, isolated samples without mutations directly above them are treated | ||
| as carrying the ancestral allele rather than as missing. Future versions of | ||
| tskit may expose options to treat missing data differently in statistics; for | ||
| now, if you need explicit control over how missing data are handled you should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| now, if you need explicit control over how missing data are handled you should | |
| now, if you need explicit control over how missing data is handled you should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fe6a5fb to
32ae37f
Compare
|
IBD extracted to #3330 |
|
I'll wait for @petrelharp before merging. |
|
This all looks good, but see comments/suggestions? |
f1a6325 to
f50727f
Compare
I thought it wise before 1.0 to do a full (automated) review that documentation lines up with the code we're running. Several hours of token crunching and 45min of human review/improvement resulted in these commits, which are best viewed as separate diffs as it's a bit of a grab-bag. I think these are all worth merging though - even if they are things we weren't planning to get to.
That there wasn't more than this to find is very reassuring, but then a lot of effort has been put in to ensure tskit's quality.