Use same root branch for ts #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously didn't actually reuse the node labels variable
Member
Author
|
Closed for the moment, as tests will rely on #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotting a single tree, I do not think we should show a root branch in a tree unless there is a mutation above the root in that tree. At the moment we show a root branch if there is a mutation above the branch in any tree in the ts (which also means we have to iterate through the entire ts when plotting a single tree)
For a whole ts, however, we should plot the root branch for all trees if any tree has a mutation above the root. This minor change does that too.