[pull] master from php:master#884
Merged
pull[bot] merged 17 commits intoturkdevops:masterfrom Apr 23, 2026
Merged
Conversation
This simplifies the definition of `zend_result`, since it's no longer a multilayered `typedef` of an anonymous enum.
Also clean-up the freeing code for the arch zend_string, we don't need to actually save the fname zend_string as it is not used afterwards
… long in `deflate_init` (#21841)
…21853) The SplFileObject iterator-desync fix in 08dad09 made spl_filesystem_file_read_ex throw "Cannot read from file" on the NULL-buffer path. SplFileObject::fgets() now throws inside the documented while (!$spl->eof()) $spl->fgets() idiom, because eof() returns false until a read attempt returns zero bytes. Keep the stricter semantics for next(), seek(), current(), fscanf(). Narrow fgets() to silent=true and return empty string on FAILURE, restoring the PHP-8.5 contract. Fixes GH-21742
…call()` (#21851) `zend_string_tolower()` might return the original string when it's already fully lowercase.
* PHP-8.4: zend_compile: Fix incorrect use of `ZVAL_NEW_STR()` in `zend_compile_call()` (#21851)
* PHP-8.5: zend_compile: Fix incorrect use of `ZVAL_NEW_STR()` in `zend_compile_call()` (#21851)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )