Skip to content

Conversation

@avdv
Copy link
Member

@avdv avdv commented Nov 6, 2023

  • remove rules_nixpkgs_core from our local registry, it is available in the BCR now
  • upgrade modules in the registry and at their usage sites

* remove rules_nixpkgs_core from our local registry, it is available in the BCR now
* upgrade modules in the registry and at their usage sites
@avdv avdv marked this pull request as ready for review November 6, 2023 15:32
@avdv avdv requested a review from aherrmann November 6, 2023 15:33
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove rules_nixpkgs_core from our local registry, it is available in the BCR now

Not sure if that's the right thing. We want to develop all our rules_nixpkgs modules at HEAD. Meaning, if we make a change to rules_nixpkgs_core, then CI should test rules_nixpkgs_cc against that changed version of rules_nixpkgs_core. If we don't have the custom registry, then we probably need module overrides in bazelrc.

@avdv
Copy link
Member Author

avdv commented Nov 6, 2023

Not sure if that's the right thing. We want to develop all our rules_nixpkgs modules at HEAD.

yes, but this is rules_haskell. :-) we are just consuming rules_nixpkgs_* and only update on demand.

@avdv avdv force-pushed the upgrade-nixpkgs-module branch from 67c1482 to 87df70c Compare November 7, 2023 08:20
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but this is rules_haskell. :-)

Oh, sorry! I thought this was in rules_nixpkgs 😅

Thank you, yes, this is great!

@avdv avdv added the merge-queue merge on green CI label Nov 7, 2023
@mergify mergify bot merged commit 75de1e4 into master Nov 7, 2023
@mergify mergify bot deleted the upgrade-nixpkgs-module branch November 7, 2023 10:22
@mergify mergify bot removed the merge-queue merge on green CI label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants