feat: support loading of new files automatically with --live
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a second attempt at #53 now that I understand the problem a bit better :) |
imnotjames
changed the title
--live
dkundel
suggested changes
Nov 2, 2019
Contributor
dkundel
left a comment
dkundel
left a comment
There was a problem hiding this comment.
Hi @imnotjames! Thank you so much for this contribution and sorry for the late reply. I added a few comments :)
this utilizes the chokidar watcher to watch all JS files under the functions directory and for all items within the assets directories. this also uses the lodash debouncer to prevent multiple files changing in quick succession (250ms) from causing too many reloads.
imnotjames
force-pushed
the
feature/53/watch-mode-parameter
branch
from
bb0166e to
1a2d83f
Compare
dkundel
approved these changes
Jan 10, 2020
|
🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a "watcher" on files being added and removed when
--liveis specified in the command line arguments.Contributing to Twilio