Add @Shrinkable to List.remove for GrowOnlyChecker - #228
Closed
Damika-Anupama wants to merge 29 commits into
Closed
Conversation
mernst
requested changes
Jul 19, 2025
mernst
left a comment
mernst
left a comment
Member
There was a problem hiding this comment.
This is missing methods removeFirst and removeLast.
Furthermore, you need to annotate methods in Collection, such as removeIf, and in Stack, such as pop, and others.
Please go through all collection classes in the JDK and annotate all methods that remove elements.
mernst
requested changes
Aug 5, 2025
Damika-Anupama
force-pushed
the
growonly-checker
branch
from
August 5, 2025 12:13
898dd89 to
ab8fa46
Compare
Author
|
I reverted 4 latest commits which were related to
Removed commits:
Since these changes are not directly related to the grow-only checker, I cherry picked them to a separate branch and put a PR: Index annotations |
Focus growonly-checker branch on @Shrinkable annotations only
mernst
requested changes
Aug 6, 2025
| * this class and provide implementations for the {@link #get(int)} and | ||
| * {@link List#size() size()} methods. | ||
| * | ||
| * <p>Note: Methods that can reduce the list size are annotated with |
Member
There was a problem hiding this comment.
Do not change the existing source code. Only add annotations. If you want to add a comment, use @CFComment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to the typetools/checker-framework PR "Growonly checker" typetools/checker-framework#7160