Reverted declaration sites for TemplateType and StaticType, added constraint to TemplateType - #25
Merged
Merged
Conversation
vudaltsov
requested review from
Etherlord,
SLaVeZ,
aivchen,
alies-dev,
klimick and
the-toster
January 27, 2024 22:36
vudaltsov
force-pushed
the
static-type-declaring-class
branch
from
January 27, 2024 23:15
6d0ac27 to
83ef99a
Compare
vudaltsov
changed the title
klimick
requested changes
Jan 28, 2024
| * @internal | ||
| * @psalm-internal Typhoon\Type | ||
| * @param non-empty-string $name | ||
| */ |
| @@ -369,9 +372,34 @@ public static function valueOf(Type $type): ValueOfType | |||
| * @psalm-pure | |||
| * @param non-empty-string $name | |||
| */ | |||
Member
There was a problem hiding this comment.
@template TType
@param Type<TType> $constraint
@return TemplateType<TType>
klimick
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is reverted due to discussion in https://www.youtube.com/live/DcObNIRECdc?si=SgeXDe80tCieUAmA&t=903.
Basically, keeping track of declaration site will allow (hopefully) to validate passed types without any additional context.