-
-
Notifications
You must be signed in to change notification settings - Fork 2
Reverted declaration sites for TemplateType and StaticType, added constraint to TemplateType #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Typhoon\Type; | ||
|
|
||
| /** | ||
| * @api | ||
| * @psalm-immutable | ||
| */ | ||
| final class AtClass | ||
| { | ||
| /** | ||
| * @var class-string | ||
| */ | ||
| public readonly string $name; | ||
|
|
||
| /** | ||
| * @internal | ||
| * @psalm-internal Typhoon\Type | ||
| * @param class-string $name | ||
| */ | ||
| public function __construct( | ||
| string $name, | ||
| ) { | ||
| $this->name = $name; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Typhoon\Type; | ||
|
|
||
| /** | ||
| * @api | ||
| * @psalm-immutable | ||
| */ | ||
| final class AtFunction | ||
| { | ||
| /** | ||
| * @var callable-string | ||
| */ | ||
| public readonly string $name; | ||
|
|
||
| /** | ||
| * @internal | ||
| * @psalm-internal Typhoon\Type | ||
| * @param callable-string $name | ||
| */ | ||
| public function __construct( | ||
| string $name, | ||
| ) { | ||
| $this->name = $name; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Typhoon\Type; | ||
|
|
||
| /** | ||
| * @api | ||
| * @psalm-immutable | ||
| */ | ||
| final class AtMethod | ||
| { | ||
| /** | ||
| * @var class-string | ||
| */ | ||
| public readonly string $class; | ||
|
|
||
| /** | ||
| * @var non-empty-string | ||
| */ | ||
| public readonly string $name; | ||
|
|
||
| /** | ||
| * @internal | ||
| * @psalm-internal Typhoon\Type | ||
| * @param class-string $class | ||
| * @param non-empty-string $name | ||
| */ | ||
| public function __construct( | ||
| string $class, | ||
| string $name, | ||
| ) { | ||
| $this->class = $class; | ||
| $this->name = $name; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,10 +265,13 @@ public static function object(string $class, Type ...$templateArguments): NamedO | |
| /** | ||
| * @psalm-pure | ||
| * @no-named-arguments | ||
| * @template TObject of object | ||
| * @param class-string<TObject> $declaredAtClass | ||
| * @return StaticType<TObject> | ||
| */ | ||
| public static function static(Type ...$templateArguments): StaticType | ||
| public static function static(string $declaredAtClass, Type ...$templateArguments): StaticType | ||
| { | ||
| return new StaticType($templateArguments); | ||
| return new StaticType($declaredAtClass, $templateArguments); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -367,11 +370,39 @@ public static function valueOf(Type $type): ValueOfType | |
|
|
||
| /** | ||
| * @psalm-pure | ||
| * @template TType | ||
| * @param non-empty-string $name | ||
| * @param Type<TType> $constraint | ||
| * @return TemplateType<TType> | ||
| */ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| public static function template(string $name, AtMethod|AtClass|AtFunction $declaredAt, Type $constraint = self::mixed): TemplateType | ||
| { | ||
| return new TemplateType($name, $declaredAt, $constraint); | ||
| } | ||
|
|
||
| /** | ||
| * @param callable-string $name | ||
| */ | ||
| public static function atFunction(string $name): AtFunction | ||
| { | ||
| return new AtFunction($name); | ||
| } | ||
|
|
||
| /** | ||
| * @param class-string $name | ||
| */ | ||
| public static function atClass(string $name): AtClass | ||
| { | ||
| return new AtClass($name); | ||
| } | ||
|
|
||
| /** | ||
| * @param class-string $class | ||
| * @param non-empty-string $name | ||
| */ | ||
| public static function template(string $name): TemplateType | ||
| public static function atMethod(string $class, string $name): AtMethod | ||
| { | ||
| return new TemplateType($name); | ||
| return new AtMethod($class, $name); | ||
| } | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@param Type<TType> $constraint