modern-zhaw-thesis:0.3.0 - #4591
Conversation
This reverts commit 03f431c.
…/typst-packages-fork into modern-zhaw-thesis-0.2.0
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Also addresses typst#4591 (comment) and typst#4591 (comment) Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 71 out of 79 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let appendix-removed-but-declaration-of-originality-references-it = ( | ||
| appendix == none | ||
| and not hide-frontmatter | ||
| and declaration-of-originality != none | ||
| and declaration-of-originality.override == none | ||
| and declaration-of-originality.text == none | ||
| and declaration-of-originality.location == none | ||
| ) |
There was a problem hiding this comment.
The guard that panics when appendix: none is set only triggers when declaration-of-originality.location == none, but the default declaration text still references @appendix:ai even when a location is provided. This means users can set appendix: none + keep the default declaration text (override/text unset) and still hit a missing-label compile error without getting this panic. Consider removing the location == none check and gating purely on whether the default declaration text is in use (e.g., override == none and text == none).
| // Note: `override` options accept Typst files, e.g. `override: [#include "my-override.typ"]`, and `none` | ||
| #show: zhaw-thesis.with( | ||
| language: languages.de, // Document language | ||
|
|
||
| cover: ( | ||
| school: none, // E.g., "School of Engineering" REQUIRED | ||
| institute: none, // E.g., "Computer Science" REQUIRED | ||
| work-type: none, // E.g., "Bachelor Thesis" REQUIRED |
There was a problem hiding this comment.
The README documents that override fields accept none, but it doesn't mention that the whole option blocks can now be set to none (e.g. cover: none, abstract: none, acknowledgements: none, declaration-of-originality: none, and biblio: none). Since this is a headline change in 0.3.0, it should be documented here so users know how to omit sections without running into panics/edge cases.
b164572 to
2f48068
Compare
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Also addresses typst#4591 (comment) and typst#4591 (comment) Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
I am submitting
Description: Allow
nonefor options, handle edge cases, fix bug in acknowledgements pageI have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE