Skip to content

modern-zhaw-thesis:0.3.0 - #4591

Closed
stanlrt wants to merge 33 commits into
typst:mainfrom
stanlrt:modern-zhaw-thesis-0.3.0
Closed

modern-zhaw-thesis:0.3.0#4591
stanlrt wants to merge 33 commits into
typst:mainfrom
stanlrt:modern-zhaw-thesis-0.3.0

Conversation

@stanlrt

@stanlrt stanlrt commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

I am submitting

  • a new package
  • an update for a package

Description: Allow none for options, handle edge cases, fix bug in acknowledgements page

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check Bot added the update A package update. label Apr 15, 2026
@stanlrt
stanlrt marked this pull request as ready for review April 15, 2026 19:24
Copilot AI review requested due to automatic review settings April 15, 2026 19:24
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
@stanlrt
stanlrt requested a review from Copilot April 17, 2026 21:58
@typst-package-check typst-package-check Bot changed the title modern-zhaw-thesis:0.3.0 modern-zhaw-thesis:0.2.0 and modern-zhaw-thesis:0.3.0 Apr 17, 2026
@typst-package-check typst-package-check Bot changed the title modern-zhaw-thesis:0.2.0 and modern-zhaw-thesis:0.3.0 modern-zhaw-thesis:0.3.0 Apr 17, 2026
stanlrt added 9 commits April 18, 2026 00:02
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 71 out of 79 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +96 to +103
let appendix-removed-but-declaration-of-originality-references-it = (
appendix == none
and not hide-frontmatter
and declaration-of-originality != none
and declaration-of-originality.override == none
and declaration-of-originality.text == none
and declaration-of-originality.location == none
)

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guard that panics when appendix: none is set only triggers when declaration-of-originality.location == none, but the default declaration text still references @appendix:ai even when a location is provided. This means users can set appendix: none + keep the default declaration text (override/text unset) and still hit a missing-label compile error without getting this panic. Consider removing the location == none check and gating purely on whether the default declaration text is in use (e.g., override == none and text == none).

Copilot uses AI. Check for mistakes.
Comment on lines +34 to +41
// Note: `override` options accept Typst files, e.g. `override: [#include "my-override.typ"]`, and `none`
#show: zhaw-thesis.with(
language: languages.de, // Document language

cover: (
school: none, // E.g., "School of Engineering" REQUIRED
institute: none, // E.g., "Computer Science" REQUIRED
work-type: none, // E.g., "Bachelor Thesis" REQUIRED

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README documents that override fields accept none, but it doesn't mention that the whole option blocks can now be set to none (e.g. cover: none, abstract: none, acknowledgements: none, declaration-of-originality: none, and biblio: none). Since this is a headline change in 0.3.0, it should be documented here so users know how to omit sections without running into panics/edge cases.

Copilot uses AI. Check for mistakes.
@stanlrt
stanlrt force-pushed the modern-zhaw-thesis-0.3.0 branch from b164572 to 2f48068 Compare April 17, 2026 22:06
@stanlrt stanlrt closed this Apr 17, 2026
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
stanlrt added a commit to stanlrt/typst-packages-fork that referenced this pull request Apr 17, 2026
Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants