Skip to content

fix: caption text area korean ime issue - #3799

Merged
zbeyens merged 2 commits into
udecode:mainfrom
siosio34:main
Nov 22, 2024
Merged

fix: caption text area korean ime issue#3799
zbeyens merged 2 commits into
udecode:mainfrom
siosio34:main

Conversation

@siosio34

Copy link
Copy Markdown
Collaborator

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

hello. When using Caption, there was an issue where each Korean character was cut off when entering Korean characters. A video is attached for explanation.

화면 기록 2024-11-22 오후 7 36 44

I thought it was an IME issue and modified the code.

And the result is as shown in the video below.

화면 기록 2024-11-22 오후 7 40 16

I didn't know how to test the plate example within the package, so I brought the source locally, modified it, and checked its operation.

I am willing to continue contributing to your project. It would be good if the contributing guidelines included guidelines on how to test immediately after changing a component or plugin.

If you don't like the source code, you can modify it at will.

@codesandbox

codesandbox Bot commented Nov 22, 2024

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot

changeset-bot Bot commented Nov 22, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3861e69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@udecode/plate-caption Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 22, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:06am

@zbeyens

zbeyens commented Nov 22, 2024

Copy link
Copy Markdown
Member

Thanks for contributing @siosio34. We don't have strict guidelines so you can continue that way. Maybe just add a changeset for each PR, using yarn changeset. When modifying a package, run yarn build:watch in that package to see the changes in the docs (yarn dev).

You can DM me on Discord if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants