[FEFLOW] fix a bug that a property vector was not allocated before use

[norihiro-w]

follow up of #1400. fix #1395

[TomFischer]

Thanks for fixing the bug. Could you please provide a tiny example for our test suite?

👍

[norihiro-w]

I added an example in ufz/ogs-data#24, which is also used in the new test

[norihiro-w]

@fabienma can you please test this PR with your example?

[norihiro-w]

TODO: update the submodule Data

[fabienma]

file for test. Current version ogs-6.0.6-513-g51eaa5f- crashes when importing the FEM file
feflw_import_test.zip

[norihiro-w]

it works on my pc. The version you tested is latest in master branch but is not including my modifications yet.

[ogsbot]

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/2714/

[ogsbot]

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/2715/

[norihiro-w]

The Jenkins error on Mac is below and is not caused by this PR. maybe @bilke is changing something there

In file included from /Users/jenkins/workspace/OGS-6/Gui/Mac-PRs/ogs/Applications/DataExplorer/DataView/DirectConditionGenerator.cpp:22:
In file included from /Users/jenkins/workspace/OGS-6/Gui/Mac-PRs/ogs/Applications/FileIO/AsciiRasterInterface.h:20:
In file included from /usr/local/include/boost/optional.hpp:15:
In file included from /usr/local/include/boost/optional/optional.hpp:1035:
/usr/local/include/boost/optional/detail/optional_reference_spec.hpp:97:78: error: 'ptr_' is a private member of 'boost::optional<MeshLib::PropertyVector<int> &>'
        explicit optional(const optional<U&>& rhs) BOOST_NOEXCEPT : ptr_(rhs.ptr_) {}
                                                                             ^
/Users/jenkins/workspace/OGS-6/Gui/Mac-PRs/ogs/Applications/DataExplorer/DataView/DirectConditionGenerator.cpp:100:58: note: in instantiation of function template specialization 'boost::optional<const MeshLib::PropertyVector<int> &>::optional<MeshLib::PropertyVector<int> >' requested here
    boost::optional<MeshLib::PropertyVector<int> const&> opt_node_id_pv(
                                                         ^
/usr/local/include/boost/optional/detail/optional_reference_spec.hpp:83:8: note: implicitly declared private here
    T* ptr_;
       ^
1 error generated.

[endJunction]

@norihiro-w The last error look like those fixed in #1383
The optional<T const&> is no longer valid. I changed it to optional<T&> const.

[bilke]

@norihiro-w See #1401.

[norihiro-w]

@bilke thanks

[ogsbot]

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.