Skip to content

activates tests on travis also for GUI builds#1400

Merged
norihiro-w merged 1 commit intoufz:masterfrom
norihiro-w:activate-tests-travis-GUI
Sep 14, 2016
Merged

activates tests on travis also for GUI builds#1400
norihiro-w merged 1 commit intoufz:masterfrom
norihiro-w:activate-tests-travis-GUI

Conversation

@norihiro-w
Copy link
Copy Markdown
Collaborator

related to #1397, currently some tests using Qt are not executed on travis, because only GUI builds include Qt and tests are deactivated for those builds. This PR activates the tests.

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

norihiro-w commented Sep 14, 2016

of course, this makes travis jobs longer. e.g. from 5min. to 17min.

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Sep 14, 2016

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/2713/

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

it seems GUI builds on Jenkins are executing tests. if Jenkins test is enough, I would close this PR.

@bilke
Copy link
Copy Markdown
Member

bilke commented Sep 14, 2016

Job run times on Travis vary a lot. Sometime non-gui jobs even take as long as over 15 mins, so feel free to merge this.

@norihiro-w norihiro-w merged commit a7923cc into ufz:master Sep 14, 2016
@norihiro-w norihiro-w deleted the activate-tests-travis-GUI branch September 14, 2016 08:05
@endJunction
Copy link
Copy Markdown
Member

So long the jobs are not aborted too often on travis because of the time limit, it's good to include more tests. We'll see.

norihiro-w pushed a commit to norihiro-w/ogs that referenced this pull request Sep 14, 2016
Yonghui56 pushed a commit to Yonghui56/ogs that referenced this pull request Sep 20, 2016
@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants