Log Files still not stored in Virtual Folders

[enkelmedia]

This is a follow up on this issue: #8280

It turns out that even tough we added this

Umbraco-CMS/src/Umbraco.Core/Logging/Serilog/LoggerConfigExtensions.cs

Line 30 in bafd058

Environment.SetEnvironmentVariable("BASEDIR", IOHelper.MapPath("/").TrimEnd("\\"), EnvironmentVariableTarget.Process);

The IOHelper does not resolve the path using HostingEnvironment.MapPath() for some reason, I'm not sure why but I guess that this is because the logger is created before the HttpContext is fully available. Somewhere around this check:

Umbraco-CMS/src/Umbraco.Core/IO/IOHelper.cs

Line 95 in 069529e

if (useHttpContext && HttpContext.Current != null)

I'm not really sure but i think that HostingEnvironment.MapPath would work in this context so I don't understand why we have to fallback on the GetRootDirectorySafe, maybe this is to facilitate unit-tests.

I need to investigate a little further but just posting this issue as a "placeholder".

Umbraco-Version: 8.8.0

[enkelmedia]

Okey, I know what went wrong here...

HostingEnvironment.MapPath() is used but... since "BaseDir" would resolve the "root of the website" (the folder where the website is located) any virtual folder would still be ignored since we're concatenating the website root with the path inside serilog.config.

I think that my suggestion here:
#9055

To add a new EnvironmentVariable for logs would make sense. Maybe the "best" solution would be to add a optional setting in web.config

Umbraco.Core.OverrideLogPath

Environment.SetEnvironmentVariable("LOGDIR", IOHelper.MapPath({settingValueHere}), EnvironmentVariableTarget.Process);

Then one could use this in serilog.config and we could update JsonLogViewer to look at Umbraco.Core.OverrideLogPath if it's configured. Any existing configuration would work as before with BASEDIR (ignoring virtual paths).

Does this make sense?

[nul800sebastiaan]

Got it, when we get the BASEDIR we just get (for example) C:\www\Mysite.com back. Then we stick (for example) \CustomLogs after that. We don't do IOHelper.MapPath("~/CustomLogs") anywhere I guess.

I really don't want to have a weird additional AppSetting just so we can create an override, seems unnecessary.

Two questions:

• Can we not somewhere during the setting up of the logger to a MapPath so it will just do the right thing?
• Why don't you put in the actual location where the logfiles need to go.. so instead of %BASEDIR%\Logs\UmbracoTraceLog.%MACHINENAME%..json make it D:\HereAreMyLogs\UmbracoTraceLog.%MACHINENAME%..json

[umbrabot]

Hiya @enkelmedia,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂