Add data model to stability policy #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
requested changes
Feb 13, 2024
Co-authored-by: Mark Davis <mark@unicode.org>
eemeli
reviewed
Feb 14, 2024
Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
eemeli
approved these changes
Feb 14, 2024
aphillips
added
Action-Item
stasm
reviewed
Feb 15, 2024
| to the data model that would result in a data model representation | ||
| based on this version being invalid. | ||
|
|
||
| > For example, existing interfaces or fields will not be removed. |
Collaborator
There was a problem hiding this comment.
What about changes to the existing fields and interfaces?
IIUC, this parts says that if we ever un-reserve, say, the % sigil, we will also need to keep it on the list of sigils inside UnsupportedAnnotation:
interface UnsupportedAnnotation {
type: "unsupported-annotation";
sigil: "!" | "%" | "^" | "&" | "*" | "+" | "<" | ">" | "?" | "~";
source: string;
}
Otherwise, (i.e. if we remove % from the list), data model representations produced by older implementations will not be valid.
What was the reason for including the sigil field in UnsupportedAnnotation? Could we move the sigil into the source?
Collaborator
There was a problem hiding this comment.
Good point. Including it in the source string would be a better choice for future compatibility.
ryzokuken
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640