chore(lint): enable clippy pedantic group and large_futures#153
chore(lint): enable clippy pedantic group and large_futures#153sachiniyer merged 3 commits intomainfrom
Conversation
Enable the full pedantic lint group, replacing individual lint entries. Add large_futures = "warn" for async stack frame monitoring. Selectively allow noisy pedantic lints: - missing_errors_doc, missing_panics_doc - must_use_candidate, return_self_not_must_use - module_name_repetitions, too_many_lines - struct_excessive_bools, similar_names Fixes all existing pedantic violations: - Inline format args (uninlined_format_args) - Use map_or/map_or_else instead of map().unwrap_or() - Collapse nested if-let in upgrade.rs - Replace wildcard match with explicit variant in repos.rs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| /// Login with an API token | ||
| Login { | ||
| /// API token (dtl_live_...) | ||
| /// API token (`dtl_live`_...) |
There was a problem hiding this comment.
🟡 Backticks in arg doc comment corrupt CLI help text
The doc comment for the token argument was changed from /// API token (dtl_live_...) to /// API token (\dtl_live`...). Since clap renders ///doc comments directly as terminal help text (not as markdown), the backticks will appear literally in the CLI output:API token (`dtl_live`...). This makes the help text confusing by visually splitting the token prefix dtl_live_into ``dtl_live`` and.... The backticks were likely added to suppress clippy::doc_markdownfrom the newly-enabled pedantic lint group, but the correct fix would be to either suppress that specific lint on this line or wrap the full identifier properly (e.g. ``dtl_live...` ``).
| /// API token (`dtl_live`_...) | |
| /// API token (dtl_live_...) |
Was this helpful? React with 👍 or 👎 to provide feedback.
The pedantic doc_markdown lint backticks dtl_live in help text, which changes the generated docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Previous generation accidentally captured cargo stderr. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
## Summary - Bumps version from 0.1.10 to 0.1.11 - The release workflow will auto-tag and build artifacts when merged to main ### Changes since v0.1.10 **Features:** - Add shell tab completion via clap_complete (#182) - Add --scan-id flag to bugs list command (#184) - Add scans list command (#163) - Add scans to the skill.md for the detail CLI (#185) - Auto-detect repository in detail-bugs skill (#160) **Fixes:** - Show user-friendly error messages instead of debug output (#129) - Continue list numbering across pages instead of resetting (#130) - Add file locking to prevent concurrent config overwrites (#131) **Chores & Refactoring:** - Replace Makefile with cargo xtask (#159) - Upgrade all dependencies to latest versions (#158) - Enable comprehensive clippy lints (pedantic, nursery, restriction) (#134, #135, #144, #152, #153, #154, #155) - Add GitHub Pages workflow for API docs (#178) - Add Scalar API reference page (#177) - Add integration tests against live API (#181) - Remove alpha warning from README (#156) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
clippy::pedanticgroup, replacing individual lint entrieslarge_futures = "warn"for async stack frame monitoringFinal lint config
Deny (hard error):
as_conversions,unwrap_used,panicWarn:
pedanticgroup,expect_used,large_futuresAllow (disabled from pedantic):
missing_errors_doc,missing_panics_doc,must_use_candidate,return_self_not_must_use,module_name_repetitions,too_many_lines,struct_excessive_bools,similar_namesTest plan
cargo clippypasses clean (0 warnings)cargo fmt -- --checkpasses🤖 Generated with Claude Code