lint: promote all warnings to deny and add restriction lints#154
Merged
sachiniyer merged 1 commit intomainfrom Mar 7, 2026
Merged
lint: promote all warnings to deny and add restriction lints#154sachiniyer merged 1 commit intomainfrom
sachiniyer merged 1 commit intomainfrom
Conversation
Promote pedantic, expect_used, and large_futures from warn to deny. Add restriction lints: dbg_macro, todo, unimplemented, mem_forget, wildcard_enum_match_arm, allow_attributes_without_reason, verbose_file_reads, rest_pat_in_fully_bound_structs. Add rust-level lints: unsafe_code and unreachable_pub as deny. Fix all violations with inline allows where needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
sachiniyer
added a commit
that referenced
this pull request
Mar 12, 2026
## Summary - Bumps version from 0.1.10 to 0.1.11 - The release workflow will auto-tag and build artifacts when merged to main ### Changes since v0.1.10 **Features:** - Add shell tab completion via clap_complete (#182) - Add --scan-id flag to bugs list command (#184) - Add scans list command (#163) - Add scans to the skill.md for the detail CLI (#185) - Auto-detect repository in detail-bugs skill (#160) **Fixes:** - Show user-friendly error messages instead of debug output (#129) - Continue list numbering across pages instead of resetting (#130) - Add file locking to prevent concurrent config overwrites (#131) **Chores & Refactoring:** - Replace Makefile with cargo xtask (#159) - Upgrade all dependencies to latest versions (#158) - Enable comprehensive clippy lints (pedantic, nursery, restriction) (#134, #135, #144, #152, #153, #154, #155) - Add GitHub Pages workflow for API docs (#178) - Add Scalar API reference page (#177) - Add integration tests against live API (#181) - Remove alpha warning from README (#156) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pedanticgroup,expect_used,large_futures— violations now break the build instead of just warningdbg_macro,todo,unimplemented,mem_forget,wildcard_enum_match_arm,allow_attributes_without_reason,verbose_file_reads,rest_pat_in_fully_bound_structsunsafe_code = "deny",unreachable_pub = "deny"logo_math.rsandlib.rs, inline#[allow(..., reason = "...")]for external enum wildcard inauth.rs, unsafe block inrender.rs, and generated code inapi/mod.rsWith inline
#[allow]requiring areason, every exception is now documented at the point of use.Test plan
cargo clippy— 0 warnings, 0 errorscargo test— 139 tests passcargo fmt --check— clean🤖 Generated with Claude Code