[pull] master from ceph:master#2303
Merged
pull[bot] merged 53 commits intousefulalgorithm:masterfrom Mar 3, 2021
Merged
Conversation
The osd_fast_shutdown option may cause the cluster log to receive too many entries of 'osd.X reported immediately failed by osd.Y', depending on cluster scale. This might be an issue for LMA stacks/tools that check ceph logs for failed lines, and then require additional logic to filter on an intended OSD (fast) shutdown; might not be an option/possible, and require an admin to analyze. So, add osd_fast_shutdown_notify_mon option for OSD to also tell the monitor it is shutting down (done in slow/non-fast shutdown) under osd_fast_shutdown. This introduces minimal delay (the ack from the mon is required to prevent the messages), and addresses the cluster log issue. Note: the osd_mon_shutdown_timeout option can be used to control the maximum amount of time waiting for the monitor ack to arrive. Fixes: http://tracker.ceph.com/issues/46978 Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Let's add the ``osd_fast_shutdown_notify_mon`` option to PendingReleaseNotes so it is documented. Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Fixes: https://tracker.ceph.com/issues/49203 Adding support for the term "notifications" in rgw_enable_apis Signed-off-by: Gaurav Sitlani <gauravsitlani@riseup.net>
1. removed symlink to `.qa/objectstore` 2. added `random-objectstore&` to `.qa/objectstore` Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Otherwise cephadm will be also included in the doc/rados toctree Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
... instead of joining path to <ceph-repo-root>/build/bin/ directory to 'ceph' everytime. Signed-off-by: Rishabh Dave <ridave@redhat.com>
LocalCephManager already inherits these methods from CephManager. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Fixes: https://tracker.ceph.com/issues/49494 Co-authored-by: Kefu Chai <tchaikov@gmail.com> Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>
to hide the implementation in .cc file, also speed up the compilation. Signed-off-by: Kefu Chai <kchai@redhat.com>
in ff65c80, we moved create_worker() call out of the constructor to avoid calling virtual functions in constructor. but this created a regression where RDMAStack's constructor tries to reference its workers not yet created. in this change, the workers are initialized right after they are created. Signed-off-by: Kefu Chai <kchai@redhat.com>
as it's not needed and confusing. Signed-off-by: Kefu Chai <kchai@redhat.com>
so we can drop the `i` parameter in a later change. also restructure DPDKStack::spawn_worker() to capture variables by value instead of by reference, we cannot assume that the variables allocated on stack are still available when the function is scheduled on another stack and core. Signed-off-by: Kefu Chai <kchai@redhat.com>
it's not needed when creating a new worker. Signed-off-by: Kefu Chai <kchai@redhat.com>
so we don't need to pass worker id to it. Signed-off-by: Kefu Chai <kchai@redhat.com>
this parameter is not used anymore. Signed-off-by: Kefu Chai <kchai@redhat.com>
there is no need to reference num_workers here. Signed-off-by: Kefu Chai <kchai@redhat.com>
prepare for dropping num_workers, the latter can be dropped in a later commit. Signed-off-by: Kefu Chai <kchai@redhat.com>
no need to store it as a member variable Signed-off-by: Kefu Chai <kchai@redhat.com>
the last user of this option was DPDKStack::DPDKStack(). which used it to initialize its func vector. but this option is not used anymore. so let's drop it. Signed-off-by: Kefu Chai <kchai@redhat.com>
and fallback to ms_type if ms_public_type is not configured otherwise rdma support breaks with ms_public_type set to async+rdma explicitly and left ms_type & ms_cluster_type to their defaults. Signed-off-by: luo.runbing <luo.runbing@zte.com.cn>
The luarocks conditional had gotten hard to read, and the openSUSE Leap 15.3 build needs lua53 as well. Signed-off-by: Nathan Cutler <ncutler@suse.com>
The message is logged everytime a binary not from Ceph repo's build directory is executed, which it too often. Signed-off-by: Rishabh Dave <ridave@redhat.com>
This commit changes the RGWStoreManager to return a RGWStore* rather than a RGWRadosStore*. This is the thread that unravels the rest of the Zipper work, removing hard-coded uses of the RGWRados* classes. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
This also removes the only user of s->sysobj_ctx, so that can be removed as well. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
The main get_user() function doesn't query the cluster, but the rest of them do. Rename the functions to match, and add comments to clarify. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
This fix was needed some years ago, but no longer. Signed-off-by: Nathan Cutler <ncutler@suse.com>
…-cephadm doc/rados: avoid including cephadm into the toctree Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Neha Ojha <nojha@redhat.com> Reviewed-by: Zac Dover <zac.dover@gmail.com>
…dos-delete valgrind: suppress operator delete[] for tcmalloc Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
…-shells-2021-Mar-03 doc/cephadm: add prompts to adoption.rst Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
rpm/luarocks: simplify conditional and support Leap 15.3 Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com> Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
rgw: added missing documentation on "pubsub" in rgw_enable_apis Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com> Reviewed-by: Casey Bodley <cbodley@redhat.com>
github-actions
bot
added
build/ops
cephadm
common
core
dashboard
documentation
mgr
rgw
tests
labels
* refs/pull/39681/head: vstart_runner: define path to ceph binary and use it Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Xiubo Li <xiubli@redhat.com>
* refs/pull/39780/head: qa/vstart_runner: dont log "not Ceph bin" msg too often Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Xiubo Li <xiubli@redhat.com>
* refs/pull/39682/head: vstart_runner: remove duplicate methods from LocalCephManager Reviewed-by: Xiubo Li <xiubli@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
rpm: set build parallelism from memory on SUSE Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: David Galloway <dgallowa@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )