ci: fix Windows release build — TUI-sidecar archive check used forward-slash paths - #990
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Greptile SummaryThe PR updates the release workflow’s PyInstaller archive sanity check to accept both forward- and backslash path separators, allowing the Windows TUI sidecar path to pass validation.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable issue identified. The changed archive check retains the expected TUI path and executable name while matching either path separator, and the available evidence shows the resulting expression works for both representative path forms. Important Files Changed
Reviews (1): Last reviewed commit: "ci: match Windows backslash paths in the..." | Re-trigger Greptile |
Summary
The v1.5.0 release build failed only on Windows: the TUI-sidecar sanity check added in #941 greps
pyi-archive_vieweroutput forstrix/bin/strix-tui.exe, but PyInstaller stores archive paths with\on Windows (strix\bin\strix-tui.exe), so the grep exits 1 right afterstrix 1.5.0prints. This check had never run on a tag before (v1.4.1 predates #941).After merge, the v1.5.0 tag needs to be moved to a commit containing this fix (or the release re-run from the fixed workflow) for the release to publish.
Link to Devin session: https://app.devin.ai/sessions/41db97c4aa2c42d2a2ce9a2ef59d7425
Requested by: @0xallam