Skip to content

ci: fix Windows release build — TUI-sidecar archive check used forward-slash paths - #990

Merged
0xallam merged 1 commit into
mainfrom
devin/1786040218-fix-release-tui-check
Aug 6, 2026
Merged

ci: fix Windows release build — TUI-sidecar archive check used forward-slash paths#990
0xallam merged 1 commit into
mainfrom
devin/1786040218-fix-release-tui-check

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The v1.5.0 release build failed only on Windows: the TUI-sidecar sanity check added in #941 greps pyi-archive_viewer output for strix/bin/strix-tui.exe, but PyInstaller stores archive paths with \ on Windows (strix\bin\strix-tui.exe), so the grep exits 1 right after strix 1.5.0 prints. This check had never run on a tag before (v1.4.1 predates #941).

- | grep "strix/bin/$TUI_NAME"
+ | grep -E "strix[/\\]bin[/\\]$TUI_NAME"

After merge, the v1.5.0 tag needs to be moved to a commit containing this fix (or the release re-run from the fixed workflow) for the release to publish.

Link to Devin session: https://app.devin.ai/sessions/41db97c4aa2c42d2a2ce9a2ef59d7425
Requested by: @0xallam

@0xallam 0xallam self-assigned this Aug 6, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates the release workflow’s PyInstaller archive sanity check to accept both forward- and backslash path separators, allowing the Windows TUI sidecar path to pass validation.

  • Replaces the fixed forward-slash match with an extended regular expression.
  • Preserves the existing platform-specific TUI executable names and release-asset validation flow.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable issue identified.

The changed archive check retains the expected TUI path and executable name while matching either path separator, and the available evidence shows the resulting expression works for both representative path forms.

Important Files Changed

Filename Overview
.github/workflows/build-release.yml Broadens the TUI-sidecar archive path check for cross-platform separators without changing release asset names or packaging behavior.

Reviews (1): Last reviewed commit: "ci: match Windows backslash paths in the..." | Re-trigger Greptile

@0xallam
0xallam merged commit c6c8bb5 into main Aug 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant