ci: tolerate repr-escaped backslashes in the release TUI-sidecar check - #991
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Greptile SummaryThis PR updates the release artifact validation to recognize Python repr-escaped Windows path separators.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The adjusted expression matches both ordinary archive paths and repr-escaped Windows paths while retaining the required directory components and exact sidecar filename. Important Files Changed
Reviews (1): Last reviewed commit: "ci: tolerate repr-escaped backslashes in..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #990 — the Windows release leg still fails:
pyi-archive_viewer -lprints TOC entries as Python reprs, so the Windows path appears with doubled backslashes ('strix\\bin\\strix-tui.exe'), which[/\\](exactly one separator) doesn't match.Verified locally that the pattern matches both
strix/bin/strix-tuiand the repr-escapedstrix\\bin\\strix-tui.exe.Link to Devin session: https://app.devin.ai/sessions/41db97c4aa2c42d2a2ce9a2ef59d7425
Requested by: @0xallam