Skip to content

ci: tolerate repr-escaped backslashes in the release TUI-sidecar check - #991

Merged
0xallam merged 1 commit into
mainfrom
devin/1786041743-fix-tui-check-v2
Aug 6, 2026
Merged

ci: tolerate repr-escaped backslashes in the release TUI-sidecar check#991
0xallam merged 1 commit into
mainfrom
devin/1786041743-fix-tui-check-v2

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #990 — the Windows release leg still fails: pyi-archive_viewer -l prints TOC entries as Python reprs, so the Windows path appears with doubled backslashes ('strix\\bin\\strix-tui.exe'), which [/\\] (exactly one separator) doesn't match.

- | grep -E "strix[/\\]bin[/\\]$TUI_NAME"
+ | grep -E "strix[/\\]+bin[/\\]+$TUI_NAME"

Verified locally that the pattern matches both strix/bin/strix-tui and the repr-escaped strix\\bin\\strix-tui.exe.

Link to Devin session: https://app.devin.ai/sessions/41db97c4aa2c42d2a2ce9a2ef59d7425
Requested by: @0xallam

@0xallam 0xallam self-assigned this Aug 6, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the release artifact validation to recognize Python repr-escaped Windows path separators.

  • Allows one or more slash or backslash characters between the expected strix/bin path components.
  • Preserves the existing platform-specific TUI filename check.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The adjusted expression matches both ordinary archive paths and repr-escaped Windows paths while retaining the required directory components and exact sidecar filename.

Important Files Changed

Filename Overview
.github/workflows/build-release.yml Broadens the PyInstaller archive-listing check to handle doubled backslashes without changing release asset construction or naming.

Reviews (1): Last reviewed commit: "ci: tolerate repr-escaped backslashes in..." | Re-trigger Greptile

@0xallam
0xallam merged commit bda0f54 into main Aug 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant