Skip to content

sum: remove .is_dir() overhead#13218

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-is-dir
Closed

sum: remove .is_dir() overhead#13218
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-is-dir

Conversation

@oech3

@oech3 oech3 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Closes #12947 . .is_dir() is really bad idea even it does not cause any security incident.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:sum-is-dir (49cf918) with main (a8edb0f)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (8a62966) during the generation of this report, so a8edb0f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oech3 oech3 marked this pull request as ready for review June 30, 2026 04:24
@oech3 oech3 force-pushed the sum-is-dir branch 2 times, most recently from e63f9e7 to 05aac8a Compare July 7, 2026 04:46
@oech3 oech3 closed this Jul 12, 2026
@oech3 oech3 deleted the sum-is-dir branch July 12, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sum: path.is_dir() has overhead of additional stat

1 participant