Skip to content

sum: remove .is_dir() overhead #13218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oech3 wants to merge 1 commit into from
+8 −7
Closed

sum: remove .is_dir() overhead #13218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/uu/sum/src/sum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,15 @@ fn open(name: &OsString) -> UResult<Reader> {

// Silent the warning as we want to the error message
match path.metadata() {
Ok(_) => {
if path.is_dir() {
return Err(USimpleError::new(
1,
translate!("sum-error-is-directory", "name" => name.maybe_quote()),
));
}
// some platforms cannot catch this as read error. Needs additional cost by stat
#[cfg(any(target_os = "wasi", target_os = "windows"))]
Ok(_) if path.is_dir() => {
return Err(USimpleError::new(
1,
translate!("sum-error-is-directory", "name" => name.maybe_quote()),
));
}
Ok(_) => {}
Err(err) => {
if err.kind() == ErrorKind::NotFound {
return Err(USimpleError::new(
Expand Down
Loading