[IO-1554][internal] CI/CD pipeline #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 24, 2023 17:03
owencjones
commented
Oct 1, 2023
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Useful addition, because YAML is valid with 4 spaced text, but GHA doesn't like it.
| with: | ||
| files: ${{ needs.get_changed_files.outputs.python_changed_files }} | ||
|
|
||
| # TODO: See Issue IO-1666 |
Contributor
Author
There was a problem hiding this comment.
Deliberately left in place, because it's ticketed next
| @@ -0,0 +1,32 @@ | |||
| name: typecheck | |||
Contributor
Author
There was a problem hiding this comment.
Not used yet, as type checking is a pain in GHA
| @@ -0,0 +1,77 @@ | |||
| #!/usr/bin/env python3 | |||
Contributor
Author
There was a problem hiding this comment.
This is a WIP to be moved to a new ticket as it is unnecessary for success of the epic
added 2 commits
October 3, 2023 11:20
Nathanjp91
approved these changes
Oct 3, 2023
Contributor
Nathanjp91
left a comment
Nathanjp91
left a comment
There was a problem hiding this comment.
Pair PR'ed with Owen over video call. Approved but lots of things to be tested in master unfortunately.
* client refactor * item object rename * delete/create classmethods * core item rename * meta object rename * Client naming consistency * remove useless asserts * remove useless asserts * collect refactor * mypy cleanup * streamlining * expanding on exceptions * __init__.py backend import changes * team backend restructure for circular reference * comment * changes to collect operation, now invalidates cache if adding to query * restructure exceptions module
* Fix for unrelated ticket * Fix to tolerate issue in place --------- Co-authored-by: Owen <owen@owencjones.co.uk>
* mypy cleanup * drop mypy settings that don't work * np typing change * remove overrides * Literal fix
* tests refactor and timing changes * tests for tests
* Error messages improved. * Update to error message * Correct typo --------- Co-authored-by: Owen <owen@owencjones.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Existing CI/CD pipeline had some issues:
mastercould not be tested for releasabilitySolution
Changelog
Added 5 new Gitgub event handler workflows
Added 11 new Github resuable jobs
Added 5 deployment utility scripts
Added one-step deployment CLI script
Rewrote deployment instructions