fix: Use String type for Style.bind return value#23888
Merged
Conversation
Change Style.bind(String, Signal<String>) return type from SignalBinding<?> to SignalBinding<String> since the method always accepts a Signal<String> and we always know the value type is String. This provides better type safety and eliminates the need for casts when using the binding's onChange callbacks. Changes: - Style.bind: return SignalBinding<String> instead of SignalBinding<?> - BasicElementStyle.bind: update implementation - ImmutableEmptyStyle.bind: update implementation - AbstractPropertyMap.bindSignal: make generic with type parameter <T> - StyleBindTest: update tests to use typed BindingContext<String> - StyleBindTest: add test to verify typed return value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Legioth
approved these changes
Mar 16, 2026
Test Results 1 384 files 1 384 suites 1h 25m 12s ⏱️ Results for commit 555e7e0. |
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Change `Style.bind(String, Signal<String>)` return type from `SignalBinding<?>` to `SignalBinding<String>` since the method always accepts a `Signal<String>` and we always know the value type is String. This provides better type safety and eliminates the need for casts when using the binding's `onChange` callbacks.
mshabarov
added a commit
that referenced
this pull request
Mar 16, 2026
Change `Style.bind(String, Signal<String>)` return type from `SignalBinding<?>` to `SignalBinding<String>` since the method always accepts a `Signal<String>` and we always know the value type is String. This provides better type safety and eliminates the need for casts when using the binding's `onChange` callbacks. Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Style.bind(String, Signal) return type from SignalBinding<?> to SignalBinding since the method always accepts a Signal and we always know the value type is String.
This provides better type safety and eliminates the need for casts when using the binding's onChange callbacks.
Changes:
🤖 Generated with Claude Code