fix: Use String type for Style.bind return value (#23888) (CP: 25.1)#23889
Merged
fix: Use String type for Style.bind return value (#23888) (CP: 25.1)#23889
Conversation
Change `Style.bind(String, Signal<String>)` return type from `SignalBinding<?>` to `SignalBinding<String>` since the method always accepts a `Signal<String>` and we always know the value type is String. This provides better type safety and eliminates the need for casts when using the binding's `onChange` callbacks.
|
Legioth
approved these changes
Mar 16, 2026
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.1.0-rc2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks changes from the original PR #23888 to branch 25.1.
Original PR description