fix: merge property descriptors when getter and setter come from different interfaces#23939
Merged
mcollovati merged 2 commits intomainfrom Mar 18, 2026
Merged
fix: merge property descriptors when getter and setter come from different interfaces#23939mcollovati merged 2 commits intomainfrom
mcollovati merged 2 commits intomainfrom
Conversation
…erent interfaces BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter.
Collaborator
|
Would this also fix #20814? |
mcollovati
reviewed
Mar 18, 2026
flow-data/src/test/java/com/vaadin/flow/data/binder/BeanPropertySetTest.java
Outdated
Show resolved
Hide resolved
Add tests for setter in child interface both with and without getter override. Remove unused MeasurementBean class. Fixes #20814
Member
Author
Seems to do that, added the test from there |
|
mcollovati
approved these changes
Mar 18, 2026
vaadin-bot
added a commit
that referenced
this pull request
Mar 18, 2026
…erent interfaces (#23939) (#23940) BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter. Fixes #20814 Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Mar 18, 2026
…erent interfaces (#23939) (#23942) BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter. Fixes #20814 Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Mar 18, 2026
…erent interfaces (#23939) (#23941) BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter. Fixes #20814 Co-authored-by: Artur Signell <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter.
Fixes #20814