Skip to content

fix: merge property descriptors when getter and setter come from different interfaces (#23939) (CP: 24.10)#23941

Merged
vaadin-bot merged 1 commit into24.10from
cherry-pick-23939-to-24.10-1773847310665
Mar 18, 2026
Merged

fix: merge property descriptors when getter and setter come from different interfaces (#23939) (CP: 24.10)#23941
vaadin-bot merged 1 commit into24.10from
cherry-pick-23939-to-24.10-1773847310665

Conversation

@vaadin-bot
Copy link
Copy Markdown
Collaborator

@vaadin-bot vaadin-bot commented Mar 18, 2026

This PR cherry-picks changes from the original PR #23939 to branch 24.10.

Original PR description

BeanUtil's dedup loop was replacing a read-only descriptor with a write-only one (or vice versa) instead of merging them. This caused BeanPropertySet to lose the getter when a parent interface provided it and a child interface provided the setter.

Fixes #20814

@Artur- @mcollovati
fix: merge property descriptors when getter and setter come from diff…
4fcc4f0 
…erent interfaces (#23939)

BeanUtil's dedup loop was replacing a read-only descriptor with a
write-only one (or vice versa) instead of merging them. This caused
BeanPropertySet to lose the getter when a parent interface provided it
and a child interface provided the setter.

Fixes #20814
@mcollovati mcollovati force-pushed the cherry-pick-23939-to-24.10-1773847310665 branch from d54a6ce to 4fcc4f0 Compare March 18, 2026 15:53
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented Mar 18, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) March 18, 2026 15:57
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented Mar 18, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 18, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Test Results

1 286 files  ± 0  1 286 suites  ±0   1h 17m 6s ⏱️ + 1m 3s
8 821 tests + 4  8 758 ✅ + 4  63 💤 ±0  0 ❌ ±0 
9 134 runs  +16  9 065 ✅ +16  69 💤 ±0  0 ❌ ±0 

Results for commit 4fcc4f0. ± Comparison against base commit 1c544a0.

@vaadin-bot vaadin-bot merged commit 88398e0 into 24.10 Mar 18, 2026
28 of 29 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-23939-to-24.10-1773847310665 branch March 18, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees

No one assigned

Labels

+0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaadin-bot @vaadin-review-bot @Artur-