feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 24.10)#24267
Merged
Conversation
…strapModifier` consumers (#24073) (CP: 25.0) (#24252) `TypeScriptBootstrapModifier` implementations (e.g., Copilot) need access to application properties to conditionally modify bootstrap TypeScript. Currently, the Copilot script is injected in dev mode regardless of whether Copilot is enabled in the project configuration. Add `withApplicationConfiguration` to `Options` and property accessor methods (`getApplicationStringProperty`, `getApplicationBooleanProperty`) that return `Optional.empty()` when configuration is unavailable (build time). Wire `ApplicationConfiguration` from `DevModeInitializer`. Fixes #24055
|
caalador
approved these changes
May 6, 2026
vaadin-bot
added a commit
that referenced
this pull request
May 6, 2026
…strapModifier` consumers (#24073) (CP: 24.10) (#24267) (CP: 24.9) (#24271) This PR cherry-picks changes from the original PR #24267 to branch 24.9. --- #### Original PR description > `TypeScriptBootstrapModifier` implementations (e.g., Copilot) need access > to application properties to conditionally modify bootstrap TypeScript. Currently, the Copilot script is injected in dev mode regardless of whether Copilot is enabled in the project configuration. > > Add `withApplicationConfiguration` to `Options` and property accessor methods (`getApplicationStringProperty`, > `getApplicationBooleanProperty`) > that return `Optional.empty()` when configuration is unavailable (build time). Wire `ApplicationConfiguration` from `DevModeInitializer`. > > Fixes #24055 Co-authored-by: Marco Collovati <marco@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.10.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScriptBootstrapModifierimplementations (e.g., Copilot) need accessto application properties to conditionally modify bootstrap TypeScript. Currently, the Copilot script is injected in dev mode regardless of whether Copilot is enabled in the project configuration.
Add
withApplicationConfigurationtoOptionsand property accessor methods (getApplicationStringProperty,getApplicationBooleanProperty)that return
Optional.empty()when configuration is unavailable (build time). WireApplicationConfigurationfromDevModeInitializer.Fixes #24055