Skip to content

feat!: add runtime license checking#24652

Merged
tltv merged 6 commits into
24.9from
feat/runtime-license-checking
Jun 23, 2026
Merged

feat!: add runtime license checking#24652
tltv merged 6 commits into
24.9from
feat/runtime-license-checking

Conversation

@tltv

@tltv tltv commented Jun 16, 2026

Copy link
Copy Markdown
Member

Verify the Vaadin license at runtime in VaadinServlet and at build time in the frontend build tool. Development mode fails on an invalid license; production mode only logs the failure so the app keeps running. Update OSGi bundle licenses to the commercial license terms. Force-off commercial banner in build plugins. Disable pre-trial licensing so trials can't be started or honored.

Verify the Vaadin license at runtime in VaadinServlet and at build time
in the frontend build tool. Development mode fails on an invalid license;
production mode only logs the failure so the app keeps running. Update
OSGi bundle licenses to the commercial license terms.
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Test Results

1 294 files   - 1  1 294 suites   - 1   1h 16m 38s ⏱️ -34s
8 912 tests  - 3  8 850 ✅  - 3  62 💤 ±0  0 ❌ ±0 
9 272 runs   - 8  9 203 ✅  - 7  69 💤  - 1  0 ❌ ±0 

Results for commit 3d5caae. ± Comparison against base commit 8c1aff1.

♻️ This comment has been updated with latest results.

tltv added 3 commits June 17, 2026 11:01
Commercial banner is changed to force-off in build plugins due to required license. Removed commercial banner tests that can't build anymore due to failing to license check.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mcollovati mcollovati requested a review from caalador June 22, 2026 11:40
@tltv tltv changed the title feat!: add runtime license checking for 24.9 feat!: add runtime license checking Jun 23, 2026
@tltv tltv merged commit db653f7 into 24.9 Jun 23, 2026
26 checks passed
@tltv tltv deleted the feat/runtime-license-checking branch June 23, 2026 07:38
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tltv and @tltv, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick db653f7
error: could not apply db653f7... feat!: add runtime license checking (#24652)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

caalador pushed a commit that referenced this pull request Jun 23, 2026
Verify the Vaadin license at runtime in VaadinServlet and at build time
in the frontend build tool. Development mode fails on an invalid
license; production mode only logs the failure so the app keeps running.
Update OSGi bundle licenses to the commercial license terms. Force-off
commercial banner in build plugins. Disable pre-trial licensing so
trials can't be started or honored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants