fix: allow UI polling while a modal component is open (#24834) (CP: 25.2)#24844
Merged
Conversation
## What changed Poll listeners registered through `PollNotifier.addPollListener` are now registered with `DomListenerRegistration::allowInert`, so they continue to fire even when a modal component makes the UI inert. A unit test in `UITest` verifies that the `ui-poll` listener keeps being invoked while a modal curtain is active. ## Why UI polling is a global, UI-level feature. It is not tied to any specific component and does not send user-controlled data to the server, so it should not be blocked by a modality curtain. Previously, opening a modal dialog caused poll events to be dropped with an `"Ignored listener invocation for ui-poll event ... inert"` message, effectively stopping polling for the duration the modal was open. Fixes #20917 Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-review-bot
approved these changes
Jun 29, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #24834 to branch 25.2.
Original PR description