feat: reuse shared metadata cache when scanning (#24887) (CP: 25.2)#24903
Merged
Conversation
Class and annotation scanning at startup runs many passes (routes, error handlers, web components, lookup, ...), each building a new `ClassPathScanner`. Because `CustomResourceLoader` does not extend `DefaultResourceLoader`, Spring's `CachingMetadataReaderFactory` falls back to a per-scan cache bounded to 256 entries instead of the application context's shared, unbounded resource cache. Parsed class metadata is therefore discarded and re-computed on every pass, slowing down startup on large classpaths. Keep the filtering `CustomResourceLoader` as the scanner's pattern resolver so package and JAR filtering is preserved, and override the scanner's `MetadataReaderFactory` with a single shared `CachingMetadataReaderFactory` backed by the application context. As the context is a `DefaultResourceLoader`, the factory now stores metadata in the context's shared cache and reuses it across all scan passes. Fixes #24881
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-review-bot
approved these changes
Jul 3, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #24887 to branch 25.2.
Original PR description