Skip to content

feat: validate URL schemes in Anchor, IFrame and Page#open (CP: 24.10)#24938

Merged
mcollovati merged 1 commit into
24.10from
cherry/cherrypick-24924-to-24.10
Jul 8, 2026
Merged

feat: validate URL schemes in Anchor, IFrame and Page#open (CP: 24.10)#24938
mcollovati merged 1 commit into
24.10from
cherry/cherrypick-24924-to-24.10

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PRs #24539 and #24897 to branch 25.1, and also disables the validation by default.

The defaults when "safeUrlSchemes" configuration is missing is adjusted, so that URL validation is disabled by default, and all URLs are considered safe. This avoids unexpected behavior changes for existing users of Flow 25.1 and below.

The URL scheme validation feature could be enabled with configuration when necessary.

(cherry picked from commit 28e55a3) (cherry picked from commit 51048d1)

…24897) (CP: 25.1) (#24924)

This PR cherry-picks changes from the original PRs #24539 and #24897 to
branch 25.1, and also disables the validation by default.

The defaults when "safeUrlSchemes" configuration is missing is adjusted,
so that URL validation is disabled by default, and all URLs are
considered safe. This avoids unexpected behavior changes for existing
users of Flow 25.1 and below.

The URL scheme validation feature could be enabled with configuration
when necessary.

(cherry picked from commit 28e55a3)
(cherry picked from commit 51048d1)
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Test Results

1 295 files  ± 0  1 295 suites  ±0   1h 16m 59s ⏱️ + 3m 25s
8 952 tests +29  8 890 ✅ +30  62 💤 ±0  0 ❌ ±0 
9 319 runs  +31  9 249 ✅ +30  70 💤 +2  0 ❌ ±0 

Results for commit 6eae250. ± Comparison against base commit d04dbaa.

@mcollovati mcollovati merged commit 2f438a9 into 24.10 Jul 8, 2026
25 of 26 checks passed
@mcollovati mcollovati deleted the cherry/cherrypick-24924-to-24.10 branch July 8, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants