chore(flow-server): remove the dead GWT client-engine bootstrap emission - #24955
chore(flow-server): remove the dead GWT client-engine bootstrap emission#24955totally-not-ai[bot] wants to merge 8 commits into
Conversation
Review — remove dead GWT client-engine bootstrap emissionCorrect and clean. Verified no fallout in
The paired Minor (optional, for consistency)An identical now-dead LGTM. |
189f26e to
eaf9955
Compare
BootstrapHandler emitted a client.nocache.js <script> and computed the GWT client engine URL, but the live client loads via Flow.ts -> FlowClient, so this path is dead once the GWT engine is gone. Remove getClientEngineUrl/getClientEngine, the CLIENT_ENGINE_NOCACHE_FILE constant and its emission in setupFrameworkLibraries, and the matching compile.properties mock in MockServletServiceSessionSetup. Nothing referenced the removed API.
…mock stub (review)
eaf9955 to
057c9fb
Compare
…v-mode banner (#24979) Small polish: - Rename `eslint.config.js` → `eslint.config.mjs` so Node treats the ESM config as a module (drops the `MODULE_TYPELESS_PACKAGE_JSON` warning) without adding `"type": "module"` (`scripts/client.js` stays CommonJS). - web-test-runner: pre-mark Lit's `dev-mode` warning as issued before any module loads, keeping the banner out of test output; scope discovery to `*Tests.ts`. **Stacked on #24955** (base `flow-server-remove-client-engine`) — merge after it. Non-draft; please review before merging. --- _Re-created from #24956 after renaming the head branch `flow-client-ts-polish` → `feature/client-ts` (the canonical branch for the full client TS migration). GitHub orphaned the original PR on rename._ Co-authored-by: Artur Signell <artur@vaadin.com>
Summary
BootstrapHandleremitted aclient.nocache.js<script>and computed the GWT client-engine URL, but the live client loads viaFlow.ts -> FlowClient, so this path is dead once GWT is gone. RemovesgetClientEngineUrl/getClientEngine, theCLIENT_ENGINE_NOCACHE_FILEconstant and its emission, and the matching mock inMockServletServiceSessionSetup.Verified: no callers of the removed API anywhere in the repo. Placed after the GWT removal so the emission is unambiguously dead.
Stacked on #24954 (base
flow-client-ts-remove-gwt) — merge after it. Non-draft; please review before merging.