Skip to content

fix: collect frontend dependencies of dev tools message handlers (CP: 24.10) (#25097) (CP: 24.9) - #25098

Merged
vaadin-bot merged 1 commit into
24.9from
cherry-pick-25097-to-24.9-1785496559253
Jul 31, 2026
Merged

fix: collect frontend dependencies of dev tools message handlers (CP: 24.10) (#25097) (CP: 24.9)#25098
vaadin-bot merged 1 commit into
24.9from
cherry-pick-25097-to-24.9-1785496559253

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #25097 to branch 24.9.

Original PR description

FrontendDependencies resolves DevToolsMessageHandler subtypes to add them as internal entry points, but the class was missing from the @HandlesTypes of DevModeStartupListener. DevModeClassFinder only knows the classes listed there and throws for anything else, and that exception was swallowed by the surrounding catch block intended for a missing dev tools classpath entry. As a result, frontend dependencies declared by dev tools plugins were silently skipped in development mode when the byte-code scanner is enabled.

… 24.10) (#25097)

FrontendDependencies resolves DevToolsMessageHandler subtypes to add
them as internal entry points, but the class was missing from the
`@HandlesTypes` of DevModeStartupListener. DevModeClassFinder only knows
the classes listed there and throws for anything else, and that
exception was swallowed by the surrounding catch block intended for a
missing dev tools classpath entry. As a result, frontend dependencies
declared by dev tools plugins were silently skipped in development mode
when the byte-code scanner is enabled.
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) July 31, 2026 11:19
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 295 files  ±0  1 295 suites  ±0   1h 14m 47s ⏱️ + 2m 24s
8 954 tests ±0  8 892 ✅ ±0  62 💤 ±0  0 ❌ ±0 
9 339 runs   - 6  9 268 ✅  - 7  71 💤 +1  0 ❌ ±0 

Results for commit 26e922b. ± Comparison against base commit bf08f80.

@vaadin-bot
vaadin-bot merged commit 3fb9f90 into 24.9 Jul 31, 2026
25 of 26 checks passed
@vaadin-bot
vaadin-bot deleted the cherry-pick-25097-to-24.9-1785496559253 branch July 31, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants