Skip to content

Add support for adding components to a UI - #428

Merged
Artur- merged 1 commit into
masterfrom
ui-add
Apr 12, 2016
Merged

Add support for adding components to a UI#428
Artur- merged 1 commit into
masterfrom
ui-add

Conversation

@Artur-

@Artur- Artur- commented Apr 12, 2016

Copy link
Copy Markdown
Member

This change is Reviewable

@Legioth

Legioth commented Apr 12, 2016

Copy link
Copy Markdown
Member

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file):
Is it add, addComponent or addComponents? We should probably decide on something and then use that for all "component container" components.


Comments from Reviewable

@Artur-

Artur- commented Apr 12, 2016

Copy link
Copy Markdown
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file):
This was the main driver behind this PR :)

add is short and easy, also makes it unnecessary to have two different methods for adding one or many components


Comments from Reviewable

@Legioth

Legioth commented Apr 12, 2016

Copy link
Copy Markdown
Member

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file):
It's also very ambiguous.

Does it make sense to have unqualified method names in all other cases as well? Some problematic cases that come to mind are void replace(Component old, Component new) and Component get(int index).


Comments from Reviewable

@Artur-

Artur- commented Apr 12, 2016

Copy link
Copy Markdown
Member Author

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file):
get should probably be getChild(int) to be consistent with getChildren


Comments from Reviewable

@Artur-
Artur- merged commit 9694c99 into master Apr 12, 2016
@Artur-
Artur- deleted the ui-add branch April 12, 2016 10:56
@pleku pleku modified the milestone: 0.0.3 Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants