Conversation
|
Reviewed 3 of 3 files at r1. hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file): Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file): add is short and easy, also makes it unnecessary to have two different methods for adding one or many components Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file): Does it make sense to have unqualified method names in all other cases as well? Some problematic cases that come to mind are Comments from Reviewable |
|
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. hummingbird-server/src/main/java/com/vaadin/ui/UI.java, line 748 [r1] (raw file): Comments from Reviewable |
This change is