Skip to content

Provide a better error when trying to insert null elements - #530

Merged
Legioth merged 3 commits into
masterfrom
element-null-insert
Apr 20, 2016
Merged

Provide a better error when trying to insert null elements#530
Legioth merged 3 commits into
masterfrom
element-null-insert

Conversation

@Artur-

@Artur- Artur- commented Apr 20, 2016

Copy link
Copy Markdown
Member

This change is Reviewable

@pleku

pleku commented Apr 20, 2016

Copy link
Copy Markdown

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Legioth

Legioth commented Apr 20, 2016

Copy link
Copy Markdown
Member

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Legioth

Legioth commented Apr 20, 2016

Copy link
Copy Markdown
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vaadin-tc

Copy link
Copy Markdown

SonarQube analysis reported 1 issue:

  • MAJOR 1 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

@Legioth
Legioth merged commit 493ddb9 into master Apr 20, 2016
@Legioth
Legioth deleted the element-null-insert branch April 20, 2016 08:53
@Legioth Legioth removed the in review label Apr 20, 2016
@pleku pleku modified the milestone: 0.0.3 Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants