Changed the handleSessionExpired logic to return a 404 instead of a 410 and added the no-cache parameter to the reply.#11556
Merged
ZheSun88 merged 1 commit intovaadin:masterfrom May 2, 2019
edler-san:issues4417
Merged
Changed the handleSessionExpired logic to return a 404 instead of a 410 and added the no-cache parameter to the reply.#11556ZheSun88 merged 1 commit intovaadin:masterfrom edler-san:issues4417
ZheSun88 merged 1 commit intovaadin:masterfrom
edler-san:issues4417
Conversation
…10. Also added the no-cache parameter to the reply. See #4417 for discussion.
ZheSun88
approved these changes
May 2, 2019
Contributor
ZheSun88
left a comment
ZheSun88
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
There's a problem with this PR: the client behaves differently for 410 and 404: https://github.com/vaadin/framework/blob/master/client/src/main/java/com/vaadin/client/communication/DefaultConnectionStateHandler.java#L149-L156 (Also, there is another place which still returns 410 when the session is expired: https://github.com/vaadin/framework/blob/master/server/src/main/java/com/vaadin/server/VaadinService.java#L1762) |
This was referenced Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4417
This change is