Expired session: use 403 Forbidden instead of 410 Gone#11859
Conversation
…ent caching in more cases. Change-Id: I9116d3b9858eb30676204c105080d821a1454316
|
I've patched this (and #11556) into the latest released Vaadin 7.7 JARs and rebuild our app with that, and it seems to work fine. At least I cannot reproduce the heartbeat caching with Safari anymore... |
|
@TatuLund the ticket numbers are apparently from the old ticketing system (https://dev.vaadin.com/). Should these be updated also in the original comments, which were copied (and adjusted) by #11556 and this PR? These are https://github.com/vaadin/framework/pull/11859/files#diff-8c63a75131409798ae94bfc088628bc6R63-R69 |
|
@TatuLund ping |
|
@ffdybuster
Yes, transition was done couple of years of ago.
That would be preferred for sake of maintenance. |
Change-Id: Icee23e774b3b98e8473dcdedbe11177a6db4f9ff
|
@TatuLund thanks! I've updated the PR to adjust all these issue numbers. |
|
@TatuLund is there a chance you can review this soon? |
|
@TatuLund is there a chance this will get reviewed somewhen? |
Ansku
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Use 403 Forbidden instead of 410 Gone when session expired. Also prevent caching in more cases.
Relates to #9759 Forward port of vaadin/framework#11859
Relates to #9759 Forward port of vaadin/framework#11859 (cherry picked from commit f229e8b)
Relates to #9759 Forward port of vaadin/framework#11859 (cherry picked from commit f229e8b)
Use 403 Forbidden instead of 410 Gone or 404 Not Found when a session is expired. Note that one 410 Gone has already been changed to 404 Not Found in #11556, but the corresponding client code was not adjusted. Since the client code already treats 404 specially, I've decided to use 403 instead (as has been earlier suggested in #4417), even though 404 would be more fitting for this error.
I've also added no-caching headers when 403 is now sent (i.e. when 410 was sent before).
Fixes #4417, updates #11556.
Check when you have completed
[ ] Valid tests for the pull request
[x] Contributing guidelines implemented
This change is