common automatic update #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Sep 19, 2023
mbaldessari
commented
- Introduce a validate-cluster target in the install target
- Increase the wait for the internal registry
- Add a note about SNOs and internal registries
- Move from resourceCustomization to resourceHealthcheck
- Fix up common/ tests
- Update tests in common/ after rebase
The validate-cluster target will be in charge of doing some sanity check
on the cluster. Initially we just check the connection to the cluster
and that at least one storageclass is available to the cluster.
Tested as follows:
1) Cluster with a storageclass (LVM in my case)
$ make validate-cluster
Checking cluster:
cluster-info: OK
storageclass: OK
2) Cluster without a storageclass:
$ make validate-cluster
Checking cluster:
cluster-info: OK
storageclass: None Found
make: *** [Makefile:99: validate-cluster] Error 1
Introduce a validate-cluster target in the install target
IIB improvements
Our resourceCustomization is currently giving the following warning:
Warning DeprecationNotice 27m ResourceCustomizations is
deprecated, please use the new formats `ResourceHealthChecks`,
`ResourceIgnoreDifferences`, and `Resource Actions` instead.
This actually becomes a problem with gitops-1.10 because it dropped
support for v1alpha versions of argoCD (it upgrades them automatically
to v1beta). So the cluster-wide argo app which is in charge of creating
the namespaced argoCD instance will always be OutOfSync as it will never
be able to set the `resourceCustomization` field.
Move to resourceHealthcheck which is the new supported way. This is also
backwards compatible with gitops-1.8.
Tested as follows:
1. Deployed 4.13 with gitops-1.10 and observed the multicloud-gitops-hub
being OutOfSync
2. Applied this patch and observed it going to green and sync correctly
3. Tested this on gitops-1.8.5 on 4.13 and deployed MCG correctly with
all apps becoming green everywhere.
Fixes: validatedpatterns/common#367
…-support Move from resourceCustomization to resourceHealthcheck
claudiol
pushed a commit
to claudiol/multicloud-gitops
that referenced
this pull request
Apr 17, 2024
…-prep-work Prep Work for letsencrypt support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.