-
Notifications
You must be signed in to change notification settings - Fork 4
"Model Workflows" section in Guides #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Model Workflows" section in Guides #209
Conversation
nrichers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admire your patience with these docs, @validbeck! I left a bunch of minor consistency comments but this PR does a really nice job of explaining complicated and UI-heavy procedural steps. 😮
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: Nik Richers <nik@validmind.ai>
|
@nrichers Made some changes to the deletion confirmation steps, as seen below:
I also annotated the screencap for the
|
Works for me! I really mainly just care about consistency. |
|
@nrichers, sorry for the back and forth! I decided to make a quick adjustment to our style guide to accommodate for UI elements that aren't clickable:
My rationale here is breaking types of interactions up with different emphasis helps accessibility (as if everything is bolded, that is confusing too), and you're right that these headers and groupings should also be styled differently than the other body text.
|
I was hoping to have a conversation on this rather than a unilateral declaration. 🙂 But I do agree that clarity here would be helpful. FWIW, I checked what Apple, Microsoft, and Google do and they're not 100% consistent but bolding is a very common way they suggest for highlighting UI elements. Google is the clearest:
Note the "any". I have to admit, I'm not a huge fan of having a double rule for bolding and italics, especially as it encourages more references to specific UI elements when users should be focusing on the interaction or using a feature. But let's maybe chat at 4 PM rather than trading GitHub comments. 😄 |
nrichers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (looks GREAT to me)!
Thank you putting this PR together and for helping us sort out our bolding of UI elements. I also appreciate the cropped screenshots, they do a lot to remove visual clutter.
For UI elements, our group decision was to bold only elements you interact with directly, e.g. by clicking. Other UI elements will just use plain text, including section headings in a page or UI elements we refer to. This decision is in keeping with your original way of referring to UI elements which is a simpler, less visually cluttered approach.
|
Made some quick changes based on our conversation yesterday:
|
Do you hold the
Thank you for making these updates and for the discussion yesterday! Maybe outside the scope of this PR, but we also use backticks (``) for emphasis, e.g. for parameter names that are part of the product. Maybe we should start a story to collect future style guide updates? |
I do have the
This is true, I'll add to the audit story. |
|
🍻 |
I understand now — yes, it looks like the Roles & Permissions page has been split up, along with other changes. I'm already chatting with Suba from ServiceRocket and have asked her about updating these docs. |








Internal Notes for Reviewers
Model Workflowssection under Guides to serve as a framework for our workflows feature.Working with model workflows
Working with workflowsin the side navCustomize resource statusesandSet up model workflowsunder "What's next"Customize resource statuses
Set up model workflows
Set up workflowsin the side navGuides
Now has a

Model workflowssection.External Release Notes
You can now manage lifecycle processes within your ValidMind Platform UI setup using workflows. Use workflows to match your organizational needs for overseeing model development, validation or implementation activities.
Check out our new documentation on working with your model workflows!
To use workflows, you'll need to: