Skip to content

set flowgraph.EOS to fgbase.EOS (not flowgraph.EOF) - #4

Merged
vectaport merged 2 commits into
masterfrom
use-eos-not-eof
Jul 17, 2026
Merged

set flowgraph.EOS to fgbase.EOS (not flowgraph.EOF)#4
vectaport merged 2 commits into
masterfrom
use-eos-not-eof

Conversation

@vectaport

Copy link
Copy Markdown
Owner

set flowgraph.EOS to fgbase.EOS (not flowgraph.EOF)

fgbase.EOS is the original error for end-of-stream in flow graphs (not to be confused with io.EOF). flowgraph.EOF was set up to be the same same fgbase.EOS, but it makes sense to call it flowgraph.EOS as well.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR renames the exported package-level variable flowgraph.EOF to flowgraph.EOS throughout the repository to align with the upstream fgbase.EOS naming convention. The underlying value is unchanged — both point to the same fgbase.EOS sentinel — so runtime behavior is identical.

  • flowgraph.go: renames the var EOF declaration to var EOS and updates its doc comment; updates two internal usages in allOfFire and oneOfFire.
  • examples/gcd.go, flowgraph_test.go: update Retrieve return sites from flowgraph.EOF to flowgraph.EOS.
  • hubcode.go: updates a single inline comment referencing "EOF" to "EOS".

Confidence Score: 5/5

Safe to merge — the rename is mechanical, all internal usages are updated, and the underlying sentinel value is unchanged.

The change is a pure identifier rename within a pre-release module. Every occurrence of flowgraph.EOF in the repository has been replaced with flowgraph.EOS, the value assigned to it is the same fgbase.EOS as before, and no logic path was altered. There are no remaining stray references, no test regressions, and no correctness concerns.

No files require special attention. The one consideration is that flowgraph.EOF is now gone with no deprecation alias, which will cause compile errors for any external consumers on their next upgrade.

Important Files Changed

Filename Overview
flowgraph.go Renames var EOF to var EOS and updates all four internal call sites; logic and value are unchanged.
examples/gcd.go Updates Retrieve return from flowgraph.EOF to flowgraph.EOS; consistent with rename.
flowgraph_test.go Updates test's rand100.Retrieve return from flowgraph.EOF to flowgraph.EOS; consistent with rename.
hubcode.go Updates a single inline comment from 'EOF' to 'EOS'; no code logic change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Retrieve / Transform / Transmit impl"] -->|"return flowgraph.EOS, flowgraph.EOS"| B["flowgraph.EOS\n(was flowgraph.EOF)"]
    B --> C["fgbase.EOS\n(same underlying value)"]
    C --> D{"fgbase hub checks\nerrors.Is(err, fgbase.EOS)"}
    D -->|"true"| E["allOfFire / oneOfFire:\nDstPut(EOS) + return EOS"]
    D -->|"false"| F["Normal data flow continues"]
    E --> G["Downstream nodes\nreceive EOS sentinel"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["Retrieve / Transform / Transmit impl"] -->|"return flowgraph.EOS, flowgraph.EOS"| B["flowgraph.EOS\n(was flowgraph.EOF)"]
    B --> C["fgbase.EOS\n(same underlying value)"]
    C --> D{"fgbase hub checks\nerrors.Is(err, fgbase.EOS)"}
    D -->|"true"| E["allOfFire / oneOfFire:\nDstPut(EOS) + return EOS"]
    D -->|"false"| F["Normal data flow continues"]
    E --> G["Downstream nodes\nreceive EOS sentinel"]
Loading

Reviews (2): Last reviewed commit: "examples/gcd.go: flowgraph.EOF -> flowgr..." | Re-trigger Greptile

@vectaport
vectaport merged commit 8e5fb32 into master Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant