set flowgraph.EOS to fgbase.EOS (not flowgraph.EOF) - #4
Conversation
Greptile SummaryThis PR renames the exported package-level variable
Confidence Score: 5/5Safe to merge — the rename is mechanical, all internal usages are updated, and the underlying sentinel value is unchanged. The change is a pure identifier rename within a pre-release module. Every occurrence of flowgraph.EOF in the repository has been replaced with flowgraph.EOS, the value assigned to it is the same fgbase.EOS as before, and no logic path was altered. There are no remaining stray references, no test regressions, and no correctness concerns. No files require special attention. The one consideration is that flowgraph.EOF is now gone with no deprecation alias, which will cause compile errors for any external consumers on their next upgrade. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Retrieve / Transform / Transmit impl"] -->|"return flowgraph.EOS, flowgraph.EOS"| B["flowgraph.EOS\n(was flowgraph.EOF)"]
B --> C["fgbase.EOS\n(same underlying value)"]
C --> D{"fgbase hub checks\nerrors.Is(err, fgbase.EOS)"}
D -->|"true"| E["allOfFire / oneOfFire:\nDstPut(EOS) + return EOS"]
D -->|"false"| F["Normal data flow continues"]
E --> G["Downstream nodes\nreceive EOS sentinel"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["Retrieve / Transform / Transmit impl"] -->|"return flowgraph.EOS, flowgraph.EOS"| B["flowgraph.EOS\n(was flowgraph.EOF)"]
B --> C["fgbase.EOS\n(same underlying value)"]
C --> D{"fgbase hub checks\nerrors.Is(err, fgbase.EOS)"}
D -->|"true"| E["allOfFire / oneOfFire:\nDstPut(EOS) + return EOS"]
D -->|"false"| F["Normal data flow continues"]
E --> G["Downstream nodes\nreceive EOS sentinel"]
Reviews (2): Last reviewed commit: "examples/gcd.go: flowgraph.EOF -> flowgr..." | Re-trigger Greptile |
set flowgraph.EOS to fgbase.EOS (not flowgraph.EOF)
fgbase.EOS is the original error for end-of-stream in flow graphs (not to be confused with io.EOF). flowgraph.EOF was set up to be the same same fgbase.EOS, but it makes sense to call it flowgraph.EOS as well.