Skip to content

Bump fgbase to cancel-on-shutdown branch (fgbase#5) -- verifies the remaining TestDotNaming leak fix - #5

Merged
vectaport merged 6 commits into
masterfrom
bump-fgbase-cancel-on-shutdown
Jul 19, 2026
Merged

Bump fgbase to cancel-on-shutdown branch (fgbase#5) -- verifies the remaining TestDotNaming leak fix#5
vectaport merged 6 commits into
masterfrom
bump-fgbase-cancel-on-shutdown

Conversation

@vectaport

Copy link
Copy Markdown
Owner

Summary

Temporary pin to verify fgbase#5 (real cancellation for Node.Run, closing the goroutine-leak gap that #4's wg.Wait()-vs-deadline fix didn't reach for non-terminating graphs like Constant->Sink). No code changes in this repo -- entirely internal to fgbase.

Test plan

  • go build . / go vet . clean against the pinned commit
  • TestChain/TestDotNaming pass under -race
  • Land alongside fgbase#5, then bump to master's merged commit as a follow-up (drop the TEMPORARY pin)

… CI can build/test fgbase#5

fgbase#5 (vectaport/fgbase#5) gives Node.Run
real cancellation via a quit channel, closing the goroutine-leak half
of the TestDotNaming race that #4 didn't reach (graphs with a
non-terminating source like Constant, which never hit wg.Wait()'s
happy path at all). No flowgraph-side code changes needed -- this is
entirely internal to fgbase's Node/Edge mechanics.

Revert this pin once fgbase#5 merges to master -- bump the require
line to master's merged commit instead.
…previous bump inherited a CI-breaking upgrade from fgbase's now-fixed go.mod
@vectaport
vectaport marked this pull request as ready for review July 19, 2026 12:44
@greptile-apps

greptile-apps Bot commented Jul 19, 2026

Copy link
Copy Markdown

Greptile Summary

This PR bumps fgbase by two days (July 16 → July 18 pseudo-version) to pick up the goroutine-leak fix from fgbase#5, which adds real cancellation for Node.Run covering non-terminating graphs (ConstantSink) that the earlier wg.Wait()/deadline fix didn't reach. No code in this repository changes.

  • go.mod: fgbase pseudo-version advanced from 20260716185028-5afd58281402 to 20260718190341-bc200363d0b2, still pointing at the cancel-on-shutdown branch rather than a tagged or master-merged commit.
  • go.sum: Both the content hash (h1:) and the go.mod hash updated consistently; all other dependency entries are unchanged.

Confidence Score: 4/5

Safe to merge as a temporary verification pin; the only risk is forgetting to follow up with a proper bump to the merged master commit.

The change is a two-line pseudo-version bump with no code modifications. The go.sum hashes are consistent and the diff is minimal. The one open item is that fgbase remains pinned to an untagged branch commit — the PR explicitly plans a follow-up bump, but until that lands the dependency graph points at a mutable branch tip.

go.mod — the temporary branch-pinned pseudo-version should be tracked and resolved once fgbase#5 merges to master.

Important Files Changed

Filename Overview
go.mod Bumps fgbase pseudo-version from 20260716185028-5afd58281402 to 20260718190341-bc200363d0b2, pinned to the cancel-on-shutdown branch commit rather than a tagged or merged-to-master SHA
go.sum Updates both the h1 content hash and go.mod hash for the new fgbase pseudo-version; all other entries unchanged and consistent

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant flowgraph as vectaport/flowgraph
    participant gomod as go.mod / go.sum
    participant proxy as GOPROXY (sum.golang.org)
    participant fgbase as vectaport/fgbase

    Note over flowgraph,fgbase: Before this PR — pinned to July 16 commit
    flowgraph->>gomod: require fgbase v0.0.0-20260716185028-5afd58281402
    gomod->>proxy: verify h1:M4PMoa4...
    proxy-->>fgbase: "resolve cancel-on-shutdown@5afd58281402"

    Note over flowgraph,fgbase: After this PR — pinned to July 18 commit (fgbase#5)
    flowgraph->>gomod: require fgbase v0.0.0-20260718190341-bc200363d0b2
    gomod->>proxy: verify h1:ZmaSqt6p...
    proxy-->>fgbase: "resolve cancel-on-shutdown@bc200363d0b2"

    Note over flowgraph,fgbase: Planned follow-up — bump to merged master SHA
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant flowgraph as vectaport/flowgraph
    participant gomod as go.mod / go.sum
    participant proxy as GOPROXY (sum.golang.org)
    participant fgbase as vectaport/fgbase

    Note over flowgraph,fgbase: Before this PR — pinned to July 16 commit
    flowgraph->>gomod: require fgbase v0.0.0-20260716185028-5afd58281402
    gomod->>proxy: verify h1:M4PMoa4...
    proxy-->>fgbase: "resolve cancel-on-shutdown@5afd58281402"

    Note over flowgraph,fgbase: After this PR — pinned to July 18 commit (fgbase#5)
    flowgraph->>gomod: require fgbase v0.0.0-20260718190341-bc200363d0b2
    gomod->>proxy: verify h1:ZmaSqt6p...
    proxy-->>fgbase: "resolve cancel-on-shutdown@bc200363d0b2"

    Note over flowgraph,fgbase: Planned follow-up — bump to merged master SHA
Loading

Reviews (1): Last reviewed commit: "updating go.sum" | Re-trigger Greptile

Comment thread go.mod
go 1.20

require github.com/vectaport/fgbase v0.0.0-20260716185028-5afd58281402
require github.com/vectaport/fgbase v0.0.0-20260718190341-bc200363d0b2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Temporary branch-pinned pseudo-version

fgbase is pinned to a branch commit (cancel-on-shutdown) rather than a tagged release or a master-merged SHA. The PR description already notes the follow-up task to bump to master once fgbase#5 lands; just flagging it here so the follow-up isn't forgotten — landing this state in master would leave the module graph depending on an untagged, branch-tip commit that could be force-pushed or rebased.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are just using pseudo-versions for now.

@vectaport
vectaport merged commit bfc7fcb into master Jul 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant