Bump fgbase to cancel-on-shutdown branch (fgbase#5) -- verifies the remaining TestDotNaming leak fix - #5
Merged
Conversation
… CI can build/test fgbase#5 fgbase#5 (vectaport/fgbase#5) gives Node.Run real cancellation via a quit channel, closing the goroutine-leak half of the TestDotNaming race that #4 didn't reach (graphs with a non-terminating source like Constant, which never hit wg.Wait()'s happy path at all). No flowgraph-side code changes needed -- this is entirely internal to fgbase's Node/Edge mechanics. Revert this pin once fgbase#5 merges to master -- bump the require line to master's merged commit instead.
…it stays RecvOne-only)
…previous bump inherited a CI-breaking upgrade from fgbase's now-fixed go.mod
…Ack stay bare and quit is RecvOne-only
vectaport
marked this pull request as ready for review
July 19, 2026 12:44
| go 1.20 | ||
|
|
||
| require github.com/vectaport/fgbase v0.0.0-20260716185028-5afd58281402 | ||
| require github.com/vectaport/fgbase v0.0.0-20260718190341-bc200363d0b2 |
There was a problem hiding this comment.
Temporary branch-pinned pseudo-version
fgbase is pinned to a branch commit (cancel-on-shutdown) rather than a tagged release or a master-merged SHA. The PR description already notes the follow-up task to bump to master once fgbase#5 lands; just flagging it here so the follow-up isn't forgotten — landing this state in master would leave the module graph depending on an untagged, branch-tip commit that could be force-pushed or rebased.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Owner
Author
There was a problem hiding this comment.
We are just using pseudo-versions for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporary pin to verify fgbase#5 (real cancellation for
Node.Run, closing the goroutine-leak gap that #4'swg.Wait()-vs-deadline fix didn't reach for non-terminating graphs likeConstant->Sink). No code changes in this repo -- entirely internal to fgbase.Test plan
go build ./go vet .clean against the pinned commitTestChain/TestDotNamingpass under-race